Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754542AbcK1Qaj (ORCPT ); Mon, 28 Nov 2016 11:30:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34340 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754278AbcK1Qab (ORCPT ); Mon, 28 Nov 2016 11:30:31 -0500 From: Vitaly Kuznetsov To: devel@linuxdriverproject.org Cc: linux-kernel@vger.kernel.org, "K. Y. Srinivasan" , Haiyang Zhang , Alex Ng Subject: [PATCH] hv: utils: properly pick TS protocol version for future hosts Date: Mon, 28 Nov 2016 17:30:27 +0100 Message-Id: <20161128163027.12117-1-vkuznets@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 28 Nov 2016 16:30:31 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1566 Lines: 47 It is reasonable to expect that future Hyper-V versions will continue supporting TimeSync v4 protocol, we, however, only pick it for VERSION_WIN10. Currently this is not an issue as VERSION_WIN10 is the maximum protocol version we can negotiate but this may change in future. Instead of hoping that we won't forget to update it when time comes I suggest we change the default now. Signed-off-by: Vitaly Kuznetsov --- drivers/hv/hv_util.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c index bcd0630..a13003f 100644 --- a/drivers/hv/hv_util.c +++ b/drivers/hv/hv_util.c @@ -382,23 +382,20 @@ static int util_probe(struct hv_device *dev, * Based on the host; initialize the framework and * service version numbers we will negotiate. */ - switch (vmbus_proto_version) { - case (VERSION_WS2008): + if (vmbus_proto_version <= VERSION_WS2008) { util_fw_version = UTIL_WS2K8_FW_VERSION; sd_srv_version = SD_VERSION_1; ts_srv_version = TS_VERSION_1; hb_srv_version = HB_VERSION_1; - break; - case(VERSION_WIN10): + } else if (vmbus_proto_version < VERSION_WIN10) { util_fw_version = UTIL_FW_VERSION; sd_srv_version = SD_VERSION; - ts_srv_version = TS_VERSION; + ts_srv_version = TS_VERSION_3; hb_srv_version = HB_VERSION; - break; - default: + } else { util_fw_version = UTIL_FW_VERSION; sd_srv_version = SD_VERSION; - ts_srv_version = TS_VERSION_3; + ts_srv_version = TS_VERSION; hb_srv_version = HB_VERSION; } -- 2.9.3