Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754802AbcK1Qav (ORCPT ); Mon, 28 Nov 2016 11:30:51 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:60876 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754728AbcK1Qad (ORCPT ); Mon, 28 Nov 2016 11:30:33 -0500 Date: Mon, 28 Nov 2016 11:30:31 -0500 (EST) Message-Id: <20161128.113031.964579744326063048.davem@davemloft.net> To: lsanfil@marvell.com Cc: eric.dumazet@gmail.com, pavel@ucw.cz, peppe.cavallaro@st.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: stmmac ethernet in kernel 4.4: coalescing related pauses? From: David Miller In-Reply-To: <920b1148-a77d-0b69-01b0-b14bcbdf8648@marvell.com> References: <20161128.095431.856183735501262965.davem@davemloft.net> <1480347103.18162.58.camel@edumazet-glaptop3.roam.corp.google.com> <920b1148-a77d-0b69-01b0-b14bcbdf8648@marvell.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 28 Nov 2016 07:31:08 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 321 Lines: 9 From: Lino Sanfilippo Date: Mon, 28 Nov 2016 16:57:35 +0100 > I wonder if the best fix would be indeed to deactivate irq coalescing > completely. > Does it make any sense at all to use it if a driver uses NAPI already? It absolutely does make sense, when it is implemented and functions properly.