Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933149AbcK1Qeb (ORCPT ); Mon, 28 Nov 2016 11:34:31 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:46394 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933033AbcK1QeT (ORCPT ); Mon, 28 Nov 2016 11:34:19 -0500 Date: Mon, 28 Nov 2016 17:31:36 +0100 (CET) From: Thomas Gleixner To: David Miller cc: bigeasy@linutronix.de, ubraun@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, rt@linutronix.de, linux-s390@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net/iucv: use explicit clean up labels in iucv_init() In-Reply-To: <20161128.112433.295947046706527102.davem@davemloft.net> Message-ID: References: <20161124091046.hixy3j4ibt7xzezr@linutronix.de> <20161124141415.llqki5vo7nqdusqv@linutronix.de> <20161124161013.dukr42y2nwscosk6@linutronix.de> <20161128.112433.295947046706527102.davem@davemloft.net> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 841 Lines: 23 On Mon, 28 Nov 2016, David Miller wrote: > From: Sebastian Andrzej Siewior > Date: Thu, 24 Nov 2016 17:10:13 +0100 > > > Ursula suggested to use explicit labels for clean up in the error path > > instead of one `out_free' label which handles multiple exits. > > Since the previous patch got already applied, here is a follow up patch. > > > > Signed-off-by: Sebastian Andrzej Siewior > > "Previous patch" doesn't tell readers anything specific enough to identify > the change you are referring to. This will be even more true years down > the line if someone tries to read this commit and figure out what you > are referring to. > > We have a standard mechanism to refer to commits, via SHA1_ID and commit > header line text, please use it. I amended the commit message. Thanks, tglx