Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933362AbcK1Qjm (ORCPT ); Mon, 28 Nov 2016 11:39:42 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:32870 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932930AbcK1Qjh (ORCPT ); Mon, 28 Nov 2016 11:39:37 -0500 Date: Mon, 28 Nov 2016 11:29:21 -0500 (EST) Message-Id: <20161128.112921.631621178188973017.davem@davemloft.net> To: niklas.cassel@axis.com Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, niklass@axis.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: stmmac: enable tx queue 0 for gmac4 IPs synthesized with multiple TX queues From: David Miller In-Reply-To: <1479998194-7113-1-git-send-email-niklass@axis.com> References: <1479998194-7113-1-git-send-email-niklass@axis.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 28 Nov 2016 07:29:58 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 662 Lines: 20 From: Niklas Cassel Date: Thu, 24 Nov 2016 15:36:33 +0100 > From: Niklas Cassel > > The dwmac4 IP can synthesized with 1-8 number of tx queues. > On an IP synthesized with DWC_EQOS_NUM_TXQ > 1, all txqueues are disabled > by default. For these IPs, the bitfield TXQEN is R/W. > > Always enable tx queue 0. The write will have no effect on IPs synthesized > with DWC_EQOS_NUM_TXQ == 1. > > The driver does still not utilize more than one tx queue in the IP. > > Signed-off-by: Niklas Cassel Alexandre, we are still waiting for your implicit/explicit ACK on this change. Thank you.