Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933136AbcK1Qwq (ORCPT ); Mon, 28 Nov 2016 11:52:46 -0500 Received: from www.sr71.net ([198.145.64.142]:46994 "EHLO blackbird.sr71.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932495AbcK1Qwp (ORCPT ); Mon, 28 Nov 2016 11:52:45 -0500 Subject: Re: [PATCH] proc: mm: export PTE sizes directly in smaps (v2) To: Vlastimil Babka , linux-kernel@vger.kernel.org References: <20161117002851.C7BACB98@viggo.jf.intel.com> <8769d52a-de0b-8c98-1e0b-e5305c5c02f3@suse.cz> Cc: hch@lst.de, akpm@linux-foundation.org, dan.j.williams@intel.com, khandual@linux.vnet.ibm.com, linux-mm@kvack.org From: Dave Hansen Message-ID: Date: Mon, 28 Nov 2016 08:52:43 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <8769d52a-de0b-8c98-1e0b-e5305c5c02f3@suse.cz> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 747 Lines: 22 On 11/24/2016 06:22 AM, Vlastimil Babka wrote: > On 11/17/2016 01:28 AM, Dave Hansen wrote: >> @@ -702,11 +707,13 @@ static int smaps_hugetlb_range(pte_t *pt >> } >> if (page) { >> int mapcount = page_mapcount(page); >> + unsigned long hpage_size = huge_page_size(hstate_vma(vma)); >> >> + mss->rss_pud += hpage_size; > > This hardcoded pud doesn't look right, doesn't the pmd/pud depend on > hpage_size? Urg, nope. Thanks for noticing that! I think we'll need something along the lines of: if (hpage_size == PUD_SIZE) mss->rss_pud += PUD_SIZE; else if (hpage_size == PMD_SIZE) mss->rss_pmd += PMD_SIZE; I'll respin and resend.