Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752458AbcK1SSZ (ORCPT ); Mon, 28 Nov 2016 13:18:25 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:36144 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753352AbcK1SSI (ORCPT ); Mon, 28 Nov 2016 13:18:08 -0500 Date: Mon, 28 Nov 2016 13:18:05 -0500 (EST) Message-Id: <20161128.131805.1395686082038152344.davem@davemloft.net> To: jasowang@redhat.com Cc: virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, hannes@redhat.com, mst@redhat.com, nhorman@redhat.com, jeder@redhat.com, myllynen@redhat.com, maxime.coquelin@redhat.com Subject: Re: [PATCH net-next] virtio-net: enable multiqueue by default From: David Miller In-Reply-To: <1480048646-17536-1-git-send-email-jasowang@redhat.com> References: <1480048646-17536-1-git-send-email-jasowang@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 28 Nov 2016 09:18:43 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1084 Lines: 27 From: Jason Wang Date: Fri, 25 Nov 2016 12:37:26 +0800 > We use single queue even if multiqueue is enabled and let admin to > enable it through ethtool later. This is used to avoid possible > regression (small packet TCP stream transmission). But looks like an > overkill since: > > - single queue user can disable multiqueue when launching qemu > - brings extra troubles for the management since it needs extra admin > tool in guest to enable multiqueue > - multiqueue performs much better than single queue in most of the > cases > > So this patch enables multiqueue by default: if #queues is less than or > equal to #vcpu, enable as much as queue pairs; if #queues is greater > than #vcpu, enable #vcpu queue pairs. > > Cc: Hannes Frederic Sowa > Cc: Michael S. Tsirkin > Cc: Neil Horman > Cc: Jeremy Eder > Cc: Marko Myllynen > Cc: Maxime Coquelin > Signed-off-by: Jason Wang Applied, thanks Jason.