Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755017AbcK1Tcz (ORCPT ); Mon, 28 Nov 2016 14:32:55 -0500 Received: from smtp2-g21.free.fr ([212.27.42.2]:52957 "EHLO smtp2-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754484AbcK1Tcp (ORCPT ); Mon, 28 Nov 2016 14:32:45 -0500 Subject: Re: Adding a .platform_init callback to sdhci_arasan_ops To: Doug Anderson , Sebastian Frias Cc: Adrian Hunter , Michal Simek , =?UTF-8?Q?S=c3=b6ren_Brinkmann?= , Jerry Huang , Ulf Hansson , Linux ARM , LKML , Linus Walleij , P L Sai Krishna References: <982d633b-e9c4-0f10-052b-e324f094d0f5@xilinx.com> <2a949ade-edd7-4690-cd6a-434ae1e663dc@intel.com> <66751ab5-59a4-ec30-07cd-44ca03694723@laposte.net> <485a747c-47e3-bc0e-093a-4ec9ab719987@laposte.net> From: Mason Message-ID: <9c783843-d0e4-92ef-d156-6826e38d9fa8@free.fr> Date: Mon, 28 Nov 2016 20:32:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0 SeaMonkey/2.46 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 749 Lines: 23 On 28/11/2016 18:46, Doug Anderson wrote: > As argued in my original patch the field "corecfg_baseclkfreq" is > documented in the generic Arasan document > > and thus is unlikely to be Rockchip specific. I downloaded the data sheet, which doesn't mention registers, but "pins" and "signals". Does that mean it is up to every platform to decide how to group these wires into individual registers? corecfg_baseclkfreq[7:0] Base Clock Frequency for SD Clock. This is the frequency of the xin_clk. How can 8 bits encode a frequency? Is there an implicit LUT? Is it a MHz count? "For maximum efficiency this should be around 200 MHz for eMMC or 208MHz (for SD3.0)" Regards.