Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754843AbcK1Tq0 (ORCPT ); Mon, 28 Nov 2016 14:46:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48686 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754777AbcK1TqR (ORCPT ); Mon, 28 Nov 2016 14:46:17 -0500 Date: Mon, 28 Nov 2016 14:46:15 -0500 From: Jessica Yu To: Arnd Bergmann Cc: Mark Rutland , AKASHI Takahiro , Kees Cook , Rusty Russell , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: module: fix DEBUG_SET_MODULE_RONX typo Message-ID: <20161128194615.GB24161@packer-debian-8-amd64.digitalocean.com> References: <20161128145931.3350661-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20161128145931.3350661-1-arnd@arndb.de> X-OS: Linux eisen.io 3.16.0-4-amd64 x86_64 User-Agent: Mutt/1.5.23 (2014-03-12) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 28 Nov 2016 19:46:16 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 844 Lines: 20 +++ Arnd Bergmann [28/11/16 15:59 +0100]: >The newly added 'rodata_enabled' global variable is protected by >the wrong #ifdef, leading to a link error when CONFIG_DEBUG_SET_MODULE_RONX >is turned on: > >kernel/module.o: In function `disable_ro_nx': >module.c:(.text.unlikely.disable_ro_nx+0x88): undefined reference to `rodata_enabled' >kernel/module.o: In function `module_disable_ro': >module.c:(.text.module_disable_ro+0x8c): undefined reference to `rodata_enabled' >kernel/module.o: In function `module_enable_ro': >module.c:(.text.module_enable_ro+0xb0): undefined reference to `rodata_enabled' > >CONFIG_SET_MODULE_RONX does not exist, so use the correct one instead. > >Fixes: 39290b389ea2 ("module: extend 'rodata=off' boot cmdline parameter to module mappings") >Signed-off-by: Arnd Bergmann Applied, thanks. Jessica