Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755687AbcK1UMt (ORCPT ); Mon, 28 Nov 2016 15:12:49 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:51418 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754874AbcK1UMS (ORCPT ); Mon, 28 Nov 2016 15:12:18 -0500 Date: Mon, 28 Nov 2016 12:12:11 -0800 From: Liu Bo To: Chris Mason , Christian Borntraeger , linux-btrfs , Linux Kernel Mailing List Subject: Re: btrfs: still lockdep splat for 4.9-rc5+ (btrfs_log_inode) Message-ID: <20161128201211.GB5005@localhost.localdomain> Reply-To: bo.li.liu@oracle.com References: <20161126134638.GA79987@clm-mbp.masoncoding.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161126134638.GA79987@clm-mbp.masoncoding.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 486 Lines: 14 On Sat, Nov 26, 2016 at 08:46:38AM -0500, Chris Mason wrote: > On Fri, Nov 25, 2016 at 10:03:25AM +0100, Christian Borntraeger wrote: > > FWIW, I still see the lockdep splat in btrfs in 4.9-rc5+ > > Filipe reworked the code to avoid taking the same lock twice. As far as I > can tell, this just needs some annotation. Besides this log_mutex, we have another false lockdep warning around block_group_cache->data_rwsem, we can use down_read_nested() to get rid of it. Thanks, -liubo