Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932283AbcK1VH2 (ORCPT ); Mon, 28 Nov 2016 16:07:28 -0500 Received: from mail-yb0-f193.google.com ([209.85.213.193]:33451 "EHLO mail-yb0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753195AbcK1VHS (ORCPT ); Mon, 28 Nov 2016 16:07:18 -0500 Date: Mon, 28 Nov 2016 16:07:16 -0500 From: Tejun Heo To: Kirtika Ruchandani Cc: Li Zefan , arnd@arndb.de, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpuset: Remove unused 'struct cpuset*' variable Message-ID: <20161128210716.GA12143@htj.duckdns.org> References: <1480049712-17224-1-git-send-email-kirtika@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1480049712-17224-1-git-send-email-kirtika@chromium.org> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 880 Lines: 22 On Thu, Nov 24, 2016 at 08:55:12PM -0800, Kirtika Ruchandani wrote: > 'struct cpuset* cs' that is set but not used, was introduced in commit > 1f7dd3e5a6e4 ("cgroup: fix handling of multi-destination migration from subtree_control enabling"). > cpuset_cancel_attach() uses css_cs(css) instead. Compiling with W=1 > gives the folllowing harmless warning, which we'd like to fix to > reduce the noise with W=1 in the kernel. > > kernel/cpuset.c: In function ‘cpuset_cancel_attach’: > kernel/cpuset.c:1502:17: warning: variable ‘cs’ set but not used [-Wunused-but-set-variable] > struct cpuset *cs; > ^ > > Fixes: 1f7dd3e5a6e4 ("cgroup: fix handling of multi-destination migration from subtree_control enabling"). > Cc: Tejun Heo > Signed-off-by: Kirtika Ruchandani Applied to cgroup/for-4.10. Thanks. -- tejun