Date: Mon, 28 Nov 2016 16:01:53 -0600
From: Rob Herring <robh@kernel.org>
To: Ryan Lee <RyanS.Lee@maximintegrated.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, mark.rutland@arm.com,
        perex@perex.cz, tiwai@suse.com, arnd@arndb.de,
        michael@amarulasolutions.com, oder_chiou@realtek.com,
        yesanishhere@gmail.com, jacob@teenage.engineering,
        Damien.Horsley@imgtec.com, bardliao@realtek.com,
        kuninori.morimoto.gx@renesas.com, petr@barix.com, lars@metafoo.de,
        nh6z@nh6z.net, alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA SoC MAX98927 driver - Initial release
Message-ID: <20161128220153.7ccbt4p3wy2fomis@rob-hp-laptop>
References: <1479877026-5172-1-git-send-email-RyanS.Lee@maximintegrated.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1479877026-5172-1-git-send-email-RyanS.Lee@maximintegrated.com>
User-Agent: Mutt/1.6.2-neo (2016-08-21)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2239
Lines: 64

On Wed, Nov 23, 2016 at 01:57:06PM +0900, Ryan Lee wrote:
> Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com>
> ---
>  .../devicetree/bindings/sound/max98927.txt         |   32 +
>  sound/soc/codecs/Kconfig                           |    5 +
>  sound/soc/codecs/Makefile                          |    2 +
>  sound/soc/codecs/max98927.c                        |  954 +++++++++++++++
>  sound/soc/codecs/max98927.h                        | 1253 ++++++++++++++++++++
>  5 files changed, 2246 insertions(+)
>  create mode 100755 Documentation/devicetree/bindings/sound/max98927.txt
>  mode change 100644 => 100755 sound/soc/codecs/Kconfig
>  mode change 100644 => 100755 sound/soc/codecs/Makefile
>  create mode 100755 sound/soc/codecs/max98927.c
>  create mode 100755 sound/soc/codecs/max98927.h
> 
> diff --git a/Documentation/devicetree/bindings/sound/max98927.txt b/Documentation/devicetree/bindings/sound/max98927.txt
> new file mode 100755
> index 0000000..ddcd332
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/max98927.txt
> @@ -0,0 +1,32 @@
> +max98927 audio CODEC
> +
> +This device supports I2C.
> +
> +Required properties:
> +
> +  - compatible : "maxim,max98927"
> +
> +  - vmon-slot-no : slot number used to send voltage information
> +                   or in inteleave mode this will be used as

s/inteleave/interleave/

What is the range of values?

> +                   interleave slot.
> +
> +  - imon-slot-no : slot number used to send current information

Range?

> +
> +  - interleave-mode : When using two MAX98927 in a system it is

These all need vendor prefix.

> +                      possible to create ADC data that that will
> +                      overflow the frame size. Digital Audio Interleave
> +                      mode provides a means to output VMON and IMON data
> +                      from two devices on a single DOUT line when running
> +                      smaller frames sizes such as 32 BCLKS per LRCLK or
> +                      48 BCLKS per LRCLK.
> +
> +  - reg : the I2C address of the device for I2C
> +
> +Example:
> +
> +codec: max98927@3a {
> +   compatible = "maxim,max98927";
> +   vmon-slot-no = <1>;
> +   imon-slot-no = <0>;
> +   reg = <0x3a>;
> +};