Message-ID: <3A9A30C7.3C62E34@colorfullife.com>
Date: Mon, 26 Feb 2001 11:32:39 +0100
From: Manfred Spraul <manfred@colorfullife.com>
MIME-Version: 1.0
To: pat@isis.co.za, linux-kernel@vger.kernel.org, jgarzik@mandrakesoft.com,
        Alan@redhat.com
Subject: Re: PROBLEM: Network hanging - Tulip driver with Netgear (Lite-On)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

I think I found the bug:

Someone (Jeff?) removed the line

	tp->advertising[phy_idx++] = reg4;

from tulip/tulip_core.c

pnic_check_duplex uses that variable :-(

There are 2 workarounds:

* change pnic_check_duplex:
s/tp->advertising[0]/tp->mii_advertise/g

* remove the new mii_advertise variable and replace it with
'tp->advertising[i]'.

Jeff, is it really a good idea to have one global mii_advertise
variable? If someone builds a card with multiple transceivers, then
they'll probably support different medias.

--
	Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/