Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756001AbcK2AHD (ORCPT <rfc822;w@1wt.eu>);
        Mon, 28 Nov 2016 19:07:03 -0500
Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:36727 "EHLO
        mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1755745AbcK2AG4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 28 Nov 2016 19:06:56 -0500
Subject: Re: [PATCH 2/2] builddeb: allow building without headers/firmware
 packages
To: Riku Voipio <riku.voipio@linaro.org>
References: <20160826081716.9435-1-andrew.donnellan@au1.ibm.com>
 <20160826081716.9435-2-andrew.donnellan@au1.ibm.com>
 <3149e502-1a4c-0413-b874-d40ed5bf4a42@au1.ibm.com>
 <CAAqcGHm_SRcrWOr+yxTy2oxgxKFwqa6-=ZHvf0M7pNCxoE7q5g@mail.gmail.com>
Cc: Michal Marek <mmarek@suse.com>,
        linux-kbuild <linux-kbuild@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
From: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Date: Tue, 29 Nov 2016 11:06:49 +1100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Icedove/45.4.0
MIME-Version: 1.0
In-Reply-To: <CAAqcGHm_SRcrWOr+yxTy2oxgxKFwqa6-=ZHvf0M7pNCxoE7q5g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-TM-AS-MML: disable
X-Content-Scanned: Fidelis XPS MAILER
x-cbid: 16112900-0044-0000-0000-00000209E3B0
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 16112900-0045-0000-0000-00000612D256
Message-Id: <0d78b326-96de-06dc-1bba-e8c3a88a27ae@au1.ibm.com>
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-28_19:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0
 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam
 adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000
 definitions=main-1611280383
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 438
Lines: 12

On 25/11/16 23:24, Riku Voipio wrote:
> I'm not a big fan of this patch. It adds some complexity as evident by
> extra indent
> level it adds. On practice developers would end up passing a long command line
> with all KDEB_NO* variables.

That's fair! I think the approach in your new patch is probably better, 
I'll review that.

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited