Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932761AbcK2BKJ (ORCPT ); Mon, 28 Nov 2016 20:10:09 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:49866 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932233AbcK2BJx (ORCPT ); Mon, 28 Nov 2016 20:09:53 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 969BD61272 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Mon, 28 Nov 2016 17:09:51 -0800 From: Stephen Boyd To: Viresh Kumar Cc: Rafael Wysocki , nm@ti.com, Viresh Kumar , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot , robh@kernel.org, d-gerlach@ti.com, broonie@kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH V4 07/10] PM / OPP: Separate out _generic_opp_set_rate() Message-ID: <20161129010951.GU6095@codeaurora.org> References: <1f8634c64ccec1d24119afea4b6bd2d7d1a911cf.1479986492.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1f8634c64ccec1d24119afea4b6bd2d7d1a911cf.1479986492.git.viresh.kumar@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 973 Lines: 36 On 11/24, Viresh Kumar wrote: > Later patches would add support for custom opp_set_rate callbacks. This > patch separates out the code for generic opp_set_rate handler in order > to prepare for that. s/opp_set_rate/set_opp/ twice? > > Signed-off-by: Viresh Kumar > Tested-by: Dave Gerlach > --- Besides the naming confusion. Reviewed-by: Stephen Boyd > @@ -1422,6 +1488,11 @@ int dev_pm_opp_set_regulators(struct device *dev, const char * const names[], > > opp_table->regulator_count = count; > > + /* Allocate block only once to pass to ->set_rate() */ _generic_set_opp()? Or just set_opp when that gets introduced in the next patch. > + ret = _allocate_set_opp_data(opp_table); > + if (ret) > + goto free_regulators; > + > mutex_unlock(&opp_table_lock); > return 0; > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project