Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754458AbcK2C1g (ORCPT ); Mon, 28 Nov 2016 21:27:36 -0500 Received: from mail-yw0-f173.google.com ([209.85.161.173]:36566 "EHLO mail-yw0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752046AbcK2C1a (ORCPT ); Mon, 28 Nov 2016 21:27:30 -0500 MIME-Version: 1.0 In-Reply-To: <583C49EA.5060504@linux.intel.com> References: <5788dd3650bed67a1551e209847ecdf732eb745b.1479986112.git.baolin.wang@linaro.org> <20161128072157.GA17504@kroah.com> <583C49EA.5060504@linux.intel.com> From: Baolin Wang Date: Tue, 29 Nov 2016 10:27:29 +0800 Message-ID: Subject: Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement To: Mathias Nyman Cc: Greg KH , mathias.nyman@intel.com, USB , LKML , Mark Brown Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1262 Lines: 45 On 28 November 2016 at 23:14, Mathias Nyman wrote: > On 28.11.2016 09:41, Baolin Wang wrote: >> >> On 28 November 2016 at 15:21, Greg KH wrote: >>> >>> On Mon, Nov 28, 2016 at 02:29:25PM +0800, Baolin Wang wrote: >>>> >>>> Hi Mathias, >>>> >>>> On 24 November 2016 at 19:16, Baolin Wang >>>> wrote: >>>>> >>>>> Since these 'return' statements are not generally useful in void >>>>> function, remove them. Also remove one unuseful 'break' statement >>>>> in xhci_setup_addressable_virt_dev() function. >>>>> >>>>> Signed-off-by: Baolin Wang >>>>> --- >>>>> Changes since v1: >>>>> - Add description of removing 'break' statement in commitlog. >>>>> --- >>>> >>>> >>>> Could you apply this patch if there are no other comments? Thanks. >>> >>> >>> Less than a week response for a simple cleanup patch? Why the rush and >>> pressure? Relax, this really isn't an important patch... >> >> >> I am sorry for the pressure, I just thought it is one simple cleanup >> patch. It is okay for me to wait for. >> > > Looks ok. > > If it applies I'll send it forward to usb-next after 4.10-rc1, > It should end up in 4.11 Thanks. -- Baolin.wang Best Regards