Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753204AbcK2DHr (ORCPT ); Mon, 28 Nov 2016 22:07:47 -0500 Received: from mga03.intel.com ([134.134.136.65]:2974 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751765AbcK2DHh (ORCPT ); Mon, 28 Nov 2016 22:07:37 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,714,1473145200"; d="scan'208";a="1091825276" Date: Tue, 29 Nov 2016 08:47:14 +0530 From: Vinod Koul To: Peter Ujfalusi Cc: dan.j.williams@intel.com, tony@atomide.com, linux@armlinux.org.uk, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, arnd@arndb.de Subject: Re: [PATCH v2 2/2] dmaengine: omap-dma: Support for slave devices with data port window Message-ID: <20161129031714.GP6408@localhost> References: <20161117125017.14954-1-peter.ujfalusi@ti.com> <20161117125017.14954-3-peter.ujfalusi@ti.com> <20161125061225.GJ2698@localhost> <985d5898-843b-c3d5-464d-f8b8a1452b43@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <985d5898-843b-c3d5-464d-f8b8a1452b43@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1642 Lines: 53 On Fri, Nov 25, 2016 at 11:38:51AM +0200, Peter Ujfalusi wrote: > > > On 11/25/2016 08:12 AM, Vinod Koul wrote: > > On Thu, Nov 17, 2016 at 02:50:17PM +0200, Peter Ujfalusi wrote: > >> @@ -921,11 +931,45 @@ static struct dma_async_tx_descriptor *omap_dma_prep_slave_sg( > >> > >> d->ccr = c->ccr | CCR_SYNC_FRAME; > >> if (dir == DMA_DEV_TO_MEM) { > >> - d->ccr |= CCR_DST_AMODE_POSTINC | CCR_SRC_AMODE_CONSTANT; > >> d->csdp = CSDP_DST_BURST_64 | CSDP_DST_PACKED; > >> + > >> + d->ccr |= CCR_DST_AMODE_POSTINC; > >> + if (port_window) { > >> + d->ccr |= CCR_SRC_AMODE_DBLIDX; > >> + d->ei = 1; > >> + /* > >> + * One frame covers the port_window and by configure > >> + * the source frame index to be -1 * (port_window - 1) > >> + * we instruct the sDMA that after a frame is processed > >> + * it should move back to the start of the window. > >> + */ > >> + d->fi = -(port_window - 1); > >> + > >> + if (port_window >= 64) > >> + d->csdp = CSDP_SRC_BURST_64 | CSDP_SRC_PACKED; > >> + else if (port_window >= 32) > >> + d->csdp = CSDP_SRC_BURST_32 | CSDP_SRC_PACKED; > >> + else if (port_window >= 16) > >> + d->csdp = CSDP_SRC_BURST_16 | CSDP_SRC_PACKED; > > > > this and other would look better with a switch.. > > I'm not sure if it will be any better: > > switch (port_window) { > case 0 ... 15: > break; > case 16 ... 31: > d->csdp = CSDP_SRC_BURST_16 | CSDP_SRC_PACKED; > break; > case 32 ... 63: > d->csdp = CSDP_SRC_BURST_32 | CSDP_SRC_PACKED; > break; > default: > d->csdp = CSDP_SRC_BURST_64 | CSDP_SRC_PACKED; > break; > } Yeah agree with you on this.. -- ~Vinod