Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754925AbcK2EJK (ORCPT ); Mon, 28 Nov 2016 23:09:10 -0500 Received: from mail-io0-f195.google.com ([209.85.223.195]:32939 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753030AbcK2EI7 (ORCPT ); Mon, 28 Nov 2016 23:08:59 -0500 MIME-Version: 1.0 In-Reply-To: <1480382148.16599.61.camel@decadent.org.uk> References: <1480382148.16599.61.camel@decadent.org.uk> From: Linus Torvalds Date: Mon, 28 Nov 2016 20:08:57 -0800 X-Google-Sender-Auth: 1sihrMRIRyob0HQ9o1lRg4bHf2E Message-ID: Subject: Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm To: Ben Hutchings Cc: Nicholas Piggin , "linux-arch@vger.kernel.org" , Linux Kbuild mailing list , Linux Kernel Mailing List , Greg Kroah-Hartman , Michal Marek , Arnd Bergmann , Ingo Molnar , Adam Borowski , Debian kernel maintainers Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1241 Lines: 36 On Mon, Nov 28, 2016 at 5:15 PM, Ben Hutchings wrote: >> >> The modversions stuff may just be too painful to bother with. Very few >> people probably use it, and the ones that do likely don't have any >> overriding reason why. > [...] > > Debian has some strong reasons: Honestly, I'd just like to see actual real patches from people who care about this. The reason I disabled it entirely was simply that the discussions had been going on forever, but nobody actually seemed to care enough to just fix the damn thing. There was all the _noise_ about "look, here's a patch", but nothing got sent to maintainers and actually actively pushed as a "this fixes a regression". At some point I just get fed up and say "this isn't worth the hot air and endless pointless blathering". What is the actual exact failure with MODVERSIONS today? IOW, if you just remove the "broken", is it actually broken, and why? Because it does work for me, I just got really tired of hearing about it, and assuming it's just some broken toolchain or other case that I just don't hit. So somebody send me a minimal patch that is (a) tested (b) explains it (c) obvious and I'll happily re-enable modversions. Linus