Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756267AbcK2HuW (ORCPT ); Tue, 29 Nov 2016 02:50:22 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:48334 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755762AbcK2HuO (ORCPT ); Tue, 29 Nov 2016 02:50:14 -0500 Subject: Re: [PATCH] lockdep: fix report formatting To: Dmitry Vyukov , peterz@infradead.org, mingo@redhat.com References: <1480343083-48731-1-git-send-email-dvyukov@google.com> Cc: aryabinin@virtuozzo.com, andreyknvl@google.com, joe@perches.com, linux-kernel@vger.kernel.org, syzkaller@googlegroups.com From: Andrew Donnellan Date: Tue, 29 Nov 2016 18:50:08 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <1480343083-48731-1-git-send-email-dvyukov@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16112907-0012-0000-0000-000001F121D6 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16112907-0013-0000-0000-000006898C6E Message-Id: <46427bf6-94bb-d204-cc9d-79a77b6c9bf7@au1.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-29_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611290132 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1018 Lines: 30 On 29/11/16 01:24, Dmitry Vyukov wrote: > Since commit 4bcc595ccd80 ("printk: reinstate KERN_CONT for printing > continuation lines") printk() requires KERN_CONT to continue log > messages. Lots of printk() in lockdep.c and print_ip_sym() don't > have it. As the result lockdep reports are completely messed. > > Add missing KERN_CONT and inline print_ip_sym() where necessary. > > Without this patch all scripts that parse kernel bug reports > are broken. So it makes sense to get this into 4.9. I'm glad someone else is looking at this, I started working on a similar patch but haven't quite finished it :) > > Cc: aryabinin@virtuozzo.com > Cc: andreyknvl@google.com > Cc: joe@perches.com > Cc: peterz@infradead.org > Cc: mingo@redhat.com > Cc: linux-kernel@vger.kernel.org > Cc: syzkaller@googlegroups.com Missing Signed-off-by. FWIW I think the pr_cont() macro looks nicer than printk(KERN_CONT ...). -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnellan@au1.ibm.com IBM Australia Limited