Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756405AbcK2IUw (ORCPT ); Tue, 29 Nov 2016 03:20:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53506 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753309AbcK2IUr (ORCPT ); Tue, 29 Nov 2016 03:20:47 -0500 Date: Tue, 29 Nov 2016 09:20:41 +0100 From: Jiri Benc To: Haishuang Yan Cc: "David S. Miller" , Hannes Frederic Sowa , Pravin B Shelar , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] vxlan: fix a potential issue when create a new vxlan fdb entry. Message-ID: <20161129092041.238279f5@griffin> In-Reply-To: <1480384776-8252-1-git-send-email-yanhaishuang@cmss.chinamobile.com> References: <1480384776-8252-1-git-send-email-yanhaishuang@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 29 Nov 2016 08:20:47 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 332 Lines: 10 On Tue, 29 Nov 2016 09:59:36 +0800, Haishuang Yan wrote: > vxlan_fdb_append may return error, so add the proper check, > otherwise it will cause memory leak. > > Signed-off-by: Haishuang Yan > > Changes in v2: > - Unnecessary to initialize rc to zero. Acked-by: Jiri Benc