Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756749AbcK2JZA (ORCPT ); Tue, 29 Nov 2016 04:25:00 -0500 Received: from lelnx193.ext.ti.com ([198.47.27.77]:59045 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756340AbcK2JYu (ORCPT ); Tue, 29 Nov 2016 04:24:50 -0500 Subject: Re: [PATCH v2] drm: tilcdc: fix parsing of some DT properties To: Bartosz Golaszewski , Tomi Valkeinen , David Airlie , Kevin Hilman , Michael Turquette , Sekhar Nori References: <1480333043-1292-1-git-send-email-bgolaszewski@baylibre.com> CC: LKML , linux-drm , Peter Ujfalusi , arm-soc From: Jyri Sarha Message-ID: Date: Tue, 29 Nov 2016 11:24:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1480333043-1292-1-git-send-email-bgolaszewski@baylibre.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1502 Lines: 41 On 11/28/16 13:37, Bartosz Golaszewski wrote: > The DT binding for tildc is not consistent with the driver code: there > are two options - 'max-width' and 'max-pixelclock' specified in the > documentation which are parsed as 'ti,max-width' and > 'ti'max-pixelclock' respectively. > > Make the driver code consistent with the binding. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Jyri Sarha I'll pick this up for a pull request that I'll send shortly. > --- > v1 -> v2: > - fix max-pixelclock too > > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > index 5efb369..bd0a3bd 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > @@ -296,12 +296,12 @@ static int tilcdc_init(struct drm_driver *ddrv, struct device *dev) > > DBG("Maximum Bandwidth Value %d", priv->max_bandwidth); > > - if (of_property_read_u32(node, "ti,max-width", &priv->max_width)) > + if (of_property_read_u32(node, "max-width", &priv->max_width)) > priv->max_width = TILCDC_DEFAULT_MAX_WIDTH; > > DBG("Maximum Horizontal Pixel Width Value %dpixels", priv->max_width); > > - if (of_property_read_u32(node, "ti,max-pixelclock", > + if (of_property_read_u32(node, "max-pixelclock", > &priv->max_pixelclock)) > priv->max_pixelclock = TILCDC_DEFAULT_MAX_PIXELCLOCK; > >