Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756739AbcK2J36 (ORCPT ); Tue, 29 Nov 2016 04:29:58 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:57458 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756704AbcK2J3w (ORCPT ); Tue, 29 Nov 2016 04:29:52 -0500 Date: Tue, 29 Nov 2016 10:29:35 +0100 From: Cornelia Huck To: Stefan Hajnoczi Cc: "Gonglei (Arei)" , "Michael S. Tsirkin" , "linux-kernel@vger.kernel.org" , "qemu-devel@nongnu.org" , "virtio-dev@lists.oasis-open.org" , "virtualization@lists.linux-foundation.org" , "linux-crypto@vger.kernel.org" , Luonengjun , "Huangweidong (C)" , "Wubin (H)" , "xin.zeng@intel.com" , Claudio Fontana , "herbert@gondor.apana.org.au" , "pasic@linux.vnet.ibm.com" , "davem@davemloft.net" , "Zhoujian (jay, Euler)" , "Hanweidong (Randy)" , "arei.gonglei@hotmail.com" , "Xuquan (Quan Xu)" , longpeng , "salvatore.benedetto@intel.com" Subject: Re: [PATCH v3] crypto: add virtio-crypto driver In-Reply-To: <20161129092549.GC5152@stefanha-x1.localdomain> References: <1480334903-6672-1-git-send-email-arei.gonglei@huawei.com> <1480334903-6672-2-git-send-email-arei.gonglei@huawei.com> <20161128162055.GB11196@stefanha-x1.localdomain> <20161128185747-mutt-send-email-mst@kernel.org> <33183CC9F5247A488A2544077AF19020DA14A7A9@DGGEMA505-MBX.china.huawei.com> <20161129092549.GC5152@stefanha-x1.localdomain> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16112909-0032-0000-0000-0000024F445F X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16112909-0033-0000-0000-00001DF486CC Message-Id: <20161129102935.405892bd.cornelia.huck@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-29_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611290162 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2173 Lines: 60 On Tue, 29 Nov 2016 09:25:49 +0000 Stefan Hajnoczi wrote: > On Tue, Nov 29, 2016 at 08:22:58AM +0000, Gonglei (Arei) wrote: > > Hi, > > > > > > > > +source "drivers/crypto/virtio/Kconfig" > > > > > > + > > > > > > endif # CRYPTO_HW > > > > > > diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile > > > > > > index ad7250f..bc53cb8 100644 > > > > > > --- a/drivers/crypto/Makefile > > > > > > +++ b/drivers/crypto/Makefile > > > > > > @@ -32,3 +32,4 @@ obj-$(CONFIG_CRYPTO_DEV_VMX) += vmx/ > > > > > > obj-$(CONFIG_CRYPTO_DEV_SUN4I_SS) += sunxi-ss/ > > > > > > obj-$(CONFIG_CRYPTO_DEV_ROCKCHIP) += rockchip/ > > > > > > obj-$(CONFIG_CRYPTO_DEV_CHELSIO) += chelsio/ > > > > > > +obj-$(CONFIG_CRYPTO_DEV_VIRTIO) += virtio/ > > > > > > diff --git a/drivers/crypto/virtio/Kconfig b/drivers/crypto/virtio/Kconfig > > > > > > new file mode 100644 > > > > > > index 0000000..ceae88c > > > > > > --- /dev/null > > > > > > +++ b/drivers/crypto/virtio/Kconfig > > > > > > @@ -0,0 +1,10 @@ > > > > > > +config CRYPTO_DEV_VIRTIO > > > > > > + tristate "VirtIO crypto driver" > > > > > > + depends on VIRTIO > > > > > > + select CRYPTO_AEAD > > > > > > + select CRYPTO_AUTHENC > > > > > > + select CRYPTO_BLKCIPHER > > > > > > > > > > Inconsistent tab vs space whitespace usage. > > > > > > > > Will fix. > > > > > > > > > + default m > > > > > > + help > > > > > > + This driver provides support for virtio crypto device. If you > > > > > > + choose 'M' here, this module will be called virtio-crypto. > > > > > > > > > > All the other virtio drivers use underscore ('_') instead of hyphen > > > > > ('-'). > > > > > > > > Except virtio-rng. > > > > > > > > > I suggest calling it virtio_crypto for consistency. > > > > > > > > OK, I will change the Makefile to fix it. > > > > > > > I tried to do this, but I failed. Because virtio_crypto.ko > > consists of more than one source file which include tree files currently, > > and virtio_crypto.ko matchs the name of virtio_crypto.c. > > That's different with all other virtio drivers. > > Can you rename virtio_crypto.c to virtio_crypto_core.c? +1 I think that's the way to go.