Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756745AbcK2Jc3 (ORCPT ); Tue, 29 Nov 2016 04:32:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34960 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756320AbcK2Jc1 (ORCPT ); Tue, 29 Nov 2016 04:32:27 -0500 Date: Tue, 29 Nov 2016 10:32:24 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Peter Foley , LKML , wangnan0@huawei.com Subject: Re: [PATCH v2] Fix objtool with clang Message-ID: <20161129093224.GA30999@krava> References: <20161127161447.GA9347@krava> <20161128024346.17371-1-pefoley2@pefoley.com> <20161128113928.GD9072@krava> <20161128150024.GG2267@redhat.com> <20161128165859.GC30148@krava> <20161128194046.GB2361@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161128194046.GB2361@redhat.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 29 Nov 2016 09:32:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1234 Lines: 30 On Mon, Nov 28, 2016 at 05:40:46PM -0200, Arnaldo Carvalho de Melo wrote: SNIP > LD /tmp/build/perf/pmu-events/pmu-events-in.o > CC /tmp/build/perf/arch/x86/util/intel-bts.o > CC /tmp/build/perf/builtin-buildid-cache.o > CC /tmp/build/perf/builtin-list.o > LD /tmp/build/perf/arch/x86/util/libperf-in.o > MKDIR /tmp/build/perf/arch/x86/tests/ > CC /tmp/build/perf/arch/x86/tests/regs_load.o > /tmp/build/perf/.plugin_jbd2.o.cmd:3: *** empty variable name. Stop. > Makefile:192: recipe for target '/tmp/build/perf/plugin_jbd2-in.o' failed > make[2]: *** [/tmp/build/perf/plugin_jbd2-in.o] Error 2 > Makefile.perf:591: recipe for target '/tmp/build/perf/libtraceevent-dynamic-list' failed > make[1]: *** [/tmp/build/perf/libtraceevent-dynamic-list] Error 2 > make[1]: *** Waiting for unfinished jobs.... ok, reproduced.. the commit changes the output of the depfile for some reason, and our fixdep does not handle it correctly and produce wrong cmd file that failed to parse.. checking for fix depfile changes ('+' is after the change): -plugin_jbd2.o: plugin_jbd2.c /usr/include/stdc-predef.h \ +plugin_jbd2.o plugin_jbd2.o: plugin_jbd2.c /usr/include/stdc-predef.h \ jirka