Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756894AbcK2KGE (ORCPT ); Tue, 29 Nov 2016 05:06:04 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:33982 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750795AbcK2KF7 (ORCPT ); Tue, 29 Nov 2016 05:05:59 -0500 Date: Tue, 29 Nov 2016 11:05:51 +0100 From: Johan Hovold To: "Ji-Ze Hong (Peter Hong)" Cc: Johan Hovold , gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw, peter_hong@fintek.com.tw, "Ji-Ze Hong (Peter Hong)" Subject: Re: [PATCH V12 1/1] usb:serial: Add Fintek F81532/534 driver Message-ID: <20161129100551.GD29872@localhost> References: <1479101879-26128-1-git-send-email-hpeter+linux_kernel@gmail.com> <20161124150425.GA30963@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1333 Lines: 33 On Tue, Nov 29, 2016 at 10:33:16AM +0800, Ji-Ze Hong (Peter Hong) wrote: > Hi Johan, > > Johan Hovold 於 2016/11/24 下午 11:04 寫道: > > On Mon, Nov 14, 2016 at 01:37:59PM +0800, Ji-Ze Hong (Peter Hong) wrote: > >> This driver is for Fintek F81532/F81534 USB to Serial Ports IC. > > >> + } > >> + > >> + if (size_bulk_out != F81534_WRITE_BUFFER_SIZE || > >> + size_bulk_in != F81534_MAX_RECEIVE_BLOCK_SIZE) { > >> + dev_err(dev, "%s: endpoints packet size not matched\n", > >> + __func__); > > > > Similarly: "unsupported endpoint max packet size\n". > > > > But just to be clear: You do want to bail out if connected at full > > speed? You could also ask usb-serial core to allocate large enough > > buffers (e.g. by setting the bulk_out_size driver field) and the host > > controller will handle partitioning. > > Yes, this product cannot run on USB full-speed currently due to the > bulk-out endpoint design. It need use 512 bytes packet size to transmit > 4 ports TX data, but USB Full-speed only provide 64 byte. The F81534 > will treat the all bulk-out data as port 0 although the host will spilt > 512byte to 8 x 64bytes packets. Ok, thanks for confirming. I'll just fix up the minor comments I had on the new probe function before applying for 4.10 (so no need to resend). Thanks for sticking with it. Johan