Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756201AbcK2LOx convert rfc822-to-8bit (ORCPT ); Tue, 29 Nov 2016 06:14:53 -0500 Received: from prv-mh.provo.novell.com ([137.65.248.74]:50230 "EHLO prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753824AbcK2LOp (ORCPT ); Tue, 29 Nov 2016 06:14:45 -0500 Message-Id: <583D712F0200007800123283@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.1 Date: Tue, 29 Nov 2016 04:14:39 -0700 From: "Jan Beulich" To: "Juergen Gross" Cc: , , , , , , , Subject: Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request pointer in case of error References: <20161125202650.GK6266@mwanda> <20161129105013.7419-1-jgross@suse.com> In-Reply-To: <20161129105013.7419-1-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 582 Lines: 15 >>> On 29.11.16 at 11:50, wrote: > --- a/drivers/scsi/xen-scsifront.c > +++ b/drivers/scsi/xen-scsifront.c > @@ -184,8 +184,6 @@ static struct vscsiif_request *scsifront_pre_req(struct vscsifrnt_info *info) > > ring_req = RING_GET_REQUEST(&(info->ring), ring->req_prod_pvt); > > - ring->req_prod_pvt++; Please note the "_pvt" suffix, which stands for "private": This field is not visible to the backend. Only ring->sring fields are shared, and the updating of the shared field happens in RING_PUSH_REQUESTS() and RING_PUSH_REQUESTS_AND_CHECK_NOTIFY(). Jan