Date: Tue, 29 Nov 2016 11:38:55 +0000
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: <broonie@kernel.org>
CC: <lgirdwood@gmail.com>, <linux-kernel@vger.kernel.org>,
        <patches@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 2/2] regulator: core: Allow enable GPIO to be specified
 using GPIOD
Message-ID: <20161129113855.GH1867@localhost.localdomain>
References: <1480419045-2275-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
 <1480419045-2275-2-git-send-email-ckeepax@opensource.wolfsonmicro.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1480419045-2275-2-git-send-email-ckeepax@opensource.wolfsonmicro.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1383
Lines: 37

On Tue, Nov 29, 2016 at 11:30:45AM +0000, Charles Keepax wrote:
> The regulator subsystem has used GPIOs internally for a while, however,
> end drivers must still specify their enable GPIO using a GPIO number. This
> patch allows the end drivers to specify the enable GPIO using GPIOD
> directly.
> 
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
>  drivers/regulator/core.c         | 38 ++++++++++++++++++++++++++------------
>  include/linux/regulator/driver.h | 14 +++++++++-----
>  2 files changed, 35 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index b3417ac..48f2813 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
>  
>  	pin->gpiod = gpiod;
> @@ -4027,14 +4042,13 @@ regulator_register(const struct regulator_desc *regulator_desc,
>  			goto clean;
>  	}
>  
> -	if ((config->ena_gpio || config->ena_gpio_initialized) &&
> -	    gpio_is_valid(config->ena_gpio)) {
> +	if (regulator_ena_gpio_valid(config)) {
>  		mutex_lock(&regulator_list_mutex);
>  		ret = regulator_ena_gpio_request(rdev, config);
>  		mutex_unlock(&regulator_list_mutex);
>  		if (ret != 0) {
>  			rdev_err(rdev, "Failed to request enable GPIO%d: %d\n",
> -				 config->ena_gpio, ret);
> +				 desc_to_gpio(config->ena_gpiod), ret);

Ah sorry small bug here I will respin.

Thanks,
Charles