Date: Tue, 29 Nov 2016 15:09:46 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Alexander Kochetkov <al.kochet@gmail.com>
cc: LKML <linux-kernel@vger.kernel.org>,
        LAK <linux-arm-kernel@lists.infradead.org>, kernel@stlinux.com,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Patrice Chotard <patrice.chotard@st.com>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] clocksource/arm_global_timer: reconfigure clockevents
 after cpufreq change
In-Reply-To: <2F6A5074-F54E-4B16-AB3D-DE7301E363FC@gmail.com>
Message-ID: <alpine.DEB.2.20.1611291508460.4358@nanos>
References: <1480421716-30782-1-git-send-email-al.kochet@gmail.com> <1480421716-30782-2-git-send-email-al.kochet@gmail.com> <alpine.DEB.2.20.1611291432290.4358@nanos> <2F6A5074-F54E-4B16-AB3D-DE7301E363FC@gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-94948636-1480428586=:4358"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1459
Lines: 36

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-94948636-1480428586=:4358
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT

On Tue, 29 Nov 2016, Alexander Kochetkov wrote:
> > 29 нояб. 2016 г., в 16:42, Thomas Gleixner <tglx@linutronix.de> написал(а):
> > 
> > The frequency change would not only affect the clockevent device, it also
> > would affect the clocksource. So the patch is incomplete, but see below.
> Looks like kernel disallow change clocksource and shed_clock rate at
> runtime. I haven’t found any function for that.
> 
> > 29 нояб. 2016 г., в 16:42, Thomas Gleixner <tglx@linutronix.de> написал(а):
> > 
> > That's broken and the clk framework should keep the CORE_PERI clock at a
> > constant rate by reprogramming the divider of the CPU clock.
> 
> Thank you for the hint.
> 
> > Assumptions w/o real impact are a perfect reason not to apply that
> > patch. This want's a proper proof that the global timer really changes and
> > this hackery is required, which I seriously doubt.
> 
> It really changes. It changes like it changes for smp-twd. I guess they are
> driven by same clock CORE_PERI.

If that happens then the whole thing wants to be disabled on those
misconfigured systems and not just hacked for nothing.

Thanks,

	tglx
--8323329-94948636-1480428586=:4358--