Date: Tue, 29 Nov 2016 15:35:47 +0100
From: Joerg Roedel <joro@8bytes.org>
To: xlpang@redhat.com
Cc: Myron Stowe <myron.stowe@gmail.com>, iommu@lists.linux-foundation.org,
        Don Brace <don.brace@microsemi.com>, Dave Young <dyoung@redhat.com>,
        kexec@lists.infradead.org, LKML <linux-kernel@vger.kernel.org>,
        Myron Stowe <myron.stowe@redhat.com>,
        David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] iommu/vt-d: Flush old iotlb for kdump when the device
 gets context mapped
Message-ID: <20161129143547.GG2078@8bytes.org>
References: <1479286950-21885-1-git-send-email-xlpang@redhat.com>
 <582C232F.6080205@redhat.com>
 <CAL-B5D1kkWE4e6P1xY1Cgkf-7+nBXH=C7g21=phEzmM4FPZRRQ@mail.gmail.com>
 <582D1A40.409@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <582D1A40.409@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 614
Lines: 15

On Thu, Nov 17, 2016 at 10:47:28AM +0800, Xunlei Pang wrote:
> As per the comment, the code here only needs to flush context caches
> for the special domain 0 which is used to tag the
> non-present/erroneous caches, seems we should flush the old domain id
> of present entries for kdump according to the analysis, other than the
> new-allocated domain id. Let me ponder more on this.

Flushing the context entry only is fine. The old domain-id will not be
re-used anyway, so there is no point in reading it out of the context
table and flush it.

Also, please add a Fixes-tag when you re-post this patch.


	Joerg