Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757744AbcK2PMu (ORCPT ); Tue, 29 Nov 2016 10:12:50 -0500 Received: from mail-wj0-f181.google.com ([209.85.210.181]:33514 "EHLO mail-wj0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753830AbcK2PMn (ORCPT ); Tue, 29 Nov 2016 10:12:43 -0500 MIME-Version: 1.0 In-Reply-To: References: <1480414363-16318-1-git-send-email-tnhuynh@apm.com> From: Tin Huynh Date: Tue, 29 Nov 2016 22:12:41 +0700 Message-ID: Subject: Re: [PATCH V5] i2c: mux: pca954x: Add ACPI support for pca954x To: Peter Rosin , Mika Westerberg Cc: Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Loc Ho , Thang Nguyen , Phong Vo , patches Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 819 Lines: 22 On Tue, Nov 29, 2016 at 5:15 PM, Peter Rosin wrote: > On 2016-11-29 11:12, Tin Huynh wrote: >> This patch enables ACPI support for mux-pca954x driver. > > Looks good, thanks! > >> Signed-off-by: Tin Huynh > > Acked-by: Peter Rosin > > Cheers, > Peter > Added Mika However , in http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/gpio/gpio-pca953x.c?id=f32517bf1ae0a2de72b3f27200233bd3ad65bfeb log , i didn't see the CONFIG_ACPI and CONFIG_PTR. I have been acked with the same patch to support for i2c-leds ( without CONFIG_ACPI) About logic , if we don't enable CONFIG_ACPI , acpi_match_table will be NULL . So , the probe functions will be not called and nothing happens. I though we should use V3 (https://lkml.org/lkml/2016/11/28/893)