Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757815AbcK2PZV (ORCPT <rfc822;w@1wt.eu>);
        Tue, 29 Nov 2016 10:25:21 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52202 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1757707AbcK2PZO (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 29 Nov 2016 10:25:14 -0500
Date: Tue, 29 Nov 2016 16:24:34 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Foley <pefoley2@pefoley.com>,
        LKML <linux-kernel@vger.kernel.org>, wangnan0@huawei.com
Subject: Re: [PATCH v2] Fix objtool with clang
Message-ID: <20161129152434.GB22691@krava>
References: <20161128024346.17371-1-pefoley2@pefoley.com>
 <20161128113928.GD9072@krava>
 <20161128150024.GG2267@redhat.com>
 <CAOFdcFN5AbMU=861S5bw+cSQQSzuGwYbWm5zyfak14NcUCjUZg@mail.gmail.com>
 <20161128165859.GC30148@krava>
 <20161128194046.GB2361@redhat.com>
 <20161129142808.GA10972@krava>
 <20161129143314.GC2361@redhat.com>
 <20161129143935.GA22691@krava>
 <20161129144904.GD2361@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161129144904.GD2361@redhat.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 29 Nov 2016 15:24:36 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2562
Lines: 50

On Tue, Nov 29, 2016 at 12:49:04PM -0200, Arnaldo Carvalho de Melo wrote:
> Em Tue, Nov 29, 2016 at 03:39:35PM +0100, Jiri Olsa escreveu:
> > On Tue, Nov 29, 2016 at 12:33:15PM -0200, Arnaldo Carvalho de Melo wrote:
> > > Em Tue, Nov 29, 2016 at 03:28:08PM +0100, Jiri Olsa escreveu:
> > > > On Mon, Nov 28, 2016 at 05:40:46PM -0200, Arnaldo Carvalho de Melo wrote:
> > > > 
> > > > SNIP
> > > > 
> > > > >   CC       /tmp/build/perf/builtin-buildid-list.o
> > > > >   LD       /tmp/build/perf/pmu-events/pmu-events-in.o
> > > > >   CC       /tmp/build/perf/arch/x86/util/intel-bts.o
> > > > >   CC       /tmp/build/perf/builtin-buildid-cache.o
> > > > >   CC       /tmp/build/perf/builtin-list.o
> > > > >   LD       /tmp/build/perf/arch/x86/util/libperf-in.o
> > > > >   MKDIR    /tmp/build/perf/arch/x86/tests/
> > > > >   CC       /tmp/build/perf/arch/x86/tests/regs_load.o
> > > > > /tmp/build/perf/.plugin_jbd2.o.cmd:3: *** empty variable name.  Stop.
> > > > > Makefile:192: recipe for target '/tmp/build/perf/plugin_jbd2-in.o' failed
> > > > > make[2]: *** [/tmp/build/perf/plugin_jbd2-in.o] Error 2
> > > > > Makefile.perf:591: recipe for target '/tmp/build/perf/libtraceevent-dynamic-list' failed
> > > > > make[1]: *** [/tmp/build/perf/libtraceevent-dynamic-list] Error 2
> > > > > make[1]: *** Waiting for unfinished jobs....
> > > > >   MKDIR    /tmp/build/perf/arch/x86/tests/
> > > > >   CC       /tmp/build/perf/arch/x86/tests/arch-tests.o
> > > > > <SNIP>
> > > > >   CC       /tmp/build/perf/util/pmu.o
> > > > >   CC       /tmp/build/perf/util/pmu-flex.o
> > > > >   LD       /tmp/build/perf/util/libperf-in.o
> > > > >   LD       /tmp/build/perf/libperf-in.o
> > > > > Makefile:108: recipe for target 'install-bin' failed
> > > > > make: *** [install-bin] Error 2
> > > > > make: Leaving directory '/home/acme/git/linux/tools/perf'
> > > > > [acme@jouet linux]$ 
> > > > 
> > > > how about following fix.. it gets rid of the -Wp,MT option completely
> > > > so it should address Peter's issue.. it also makes fixdep more robust
> > > > and makes it wait for first target before spitting out dependencies
> > > 
> > > So this should replace Peter's patch? On top? I'm checking that now...
> > 
> > it's replacement.. also I'll put it into 2 patches
> 
> Ok, just tested, Peter's patch works if I remove ccache, with your patch
> replacing it, everything works, with and without ccache, on f25, and it
> builds on f24 without ccache, in one of the containers I have.

ok, I'll run my tests once I have the server and send it out

thanks,
jirka