Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933737AbcK2Pe6 (ORCPT ); Tue, 29 Nov 2016 10:34:58 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:38901 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933392AbcK2Pet (ORCPT ); Tue, 29 Nov 2016 10:34:49 -0500 X-AuditID: cbfec7f5-f79ce6d000004c54-88-583da015f581 Subject: Re: [PATCH] leds: netxbig: fix module autoload for OF registration To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Richard Purdie , linux-leds@vger.kernel.org From: Jacek Anaszewski Message-id: Date: Tue, 29 Nov 2016 16:34:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <9f84c025-7835-1664-60df-092b80a4ade7@osg.samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGIsWRmVeSWpSXmKPExsWy7djPc7qiC2wjDPa8Zrd483YNk8XlXXPY LLa+WcdosXvXU1YHFo8t/XfZPfbM/8Hq8XmTXABzFJdNSmpOZllqkb5dAldGy5NpLAXzOCp+ TstpYDzM1sXIySEhYCKxcdoddghbTOLCvfVAcS4OIYGljBJXj3WzQzifGSXe96+F61g8ewMT RGIZo8SFte9ZIJxnjBI/H3xkBqkSFvCWeLt5HViHiICpxK+1L1hBbGaBJIkV93exgNhsAoYS P1+8ZgKxeQXsJCY9+8sIYrMIqEpsvXkTqIaDQ1QgQmL33VSIEkGJH5PvgYU5BZwlujZaQUx0 lHiwaCfUdHmJzWveMoOcIyHwnU1iQccmVpB6CQFZiU0HmCHud5HoeD4J6hdhiVfHt0B9LyPR 2XGQCaJ3MqPExWM3WSGc1YwSGzs7WSCqrCUa/v9igdjGJzFp23RmiAW8Eh1tQhCmh8SfzxkQ 1Y4SP360M0OC5zKjxOk/L5gnMMrPQvLOLCQ/zELywwJG5lWMIqmlxbnpqcWmesWJucWleel6 yfm5mxiBqeH0v+NfdzAuPWZ1iFGAg1GJh/fFBNsIIdbEsuLK3EOMEhzMSiK8+2cDhXhTEiur Uovy44tKc1KLDzFKc7AoifPuWXAlXEggPbEkNTs1tSC1CCbLxMEp1cAobZwgmzrDdiOPPfdO Lpu0fzqfHB0Kgl71LPoSacVtrxuXHHfg94IfDzKyPWMfZRQ0JrSma1zNvjZX8GoVq8W8A/K7 l02v8XI3FZW8+qNC97nezXPreVwr387olM66PE/NbJPnSbtX+ZNtF7PcyrTqFJHj3vzZUf2b 8P2s8JlfPxa6lcRs5FZiKc5INNRiLipOBAD9NREUCQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprOIsWRmVeSWpSXmKPExsVy+t/xa7qqC2wjDE5uYLJ483YNk8XlXXPY LLa+WcdosXvXU1YHFo8t/XfZPfbM/8Hq8XmTXABzlJtNRmpiSmqRQmpecn5KZl66rVJoiJuu hZJCXmJuqq1ShK5vSJCSQlliTimQZ2SABhycA9yDlfTtEtwyWp5MYymYx1Hxc1pOA+Nhti5G Tg4JAROJxbM3MEHYYhIX7q0HinNxCAksYZQ4N2EfK4TzjFHiWuM1RpAqYQFvibeb14F1iwiY Svxa+wKq6DKjxJWf31hAEswCSRKr1x8Aa2ATMJT4+eI12ApeATuJSc/+gsVZBFQltt68CVYv KhAhcWvVR0aIGkGJH5PvAcU5ODgFnCW6NlpBjLSVWPB+HdR4eYnNa94yT2AUmIWkYxaSsllI yhYwMq9iFEktLc5Nzy021CtOzC0uzUvXS87P3cQIjJRtx35u3sF4aWPwIUYBDkYlHt4JfbYR QqyJZcWVuYcYJTiYlUR4988GCvGmJFZWpRblxxeV5qQWH2I0BfphIrOUaHI+MIrzSuINTQzN LQ2NjC0szI2MlMR5Sz5cCRcSSE8sSc1OTS1ILYLpY+LglGpgnK7xXD/7m0FW94sn58WWBL04 vmN9icQ0Uc8NZ6Jf2n+Ibt7gbBD4vsQryTC2sThJZ8rUY+w8+1+d6t72XO1S2o+cr4cWWprc u8Xa+dtcZZ6wcMr7t5yO2pGPPoT/2j87f/OcRk+3g1ob2TauKyhbHdrOcij8W07XqfdXri7J 732ZrXFiYuyKNUosxRmJhlrMRcWJAEeUia6qAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161129153444eucas1p1d8d0964287abd77d7fc643d598afed82 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?Qikb7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?QikbU2Ftc3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgU29mdHdhcmUgRW5naW5l?= =?UTF-8?B?ZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjc1MjY=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161129150039epcas3p34ee8ce41975cd81f0c8332f3d6898a11 X-RootMTR: 20161129150039epcas3p34ee8ce41975cd81f0c8332f3d6898a11 References: <1477065125-20877-1-git-send-email-javier@osg.samsung.com> <9f84c025-7835-1664-60df-092b80a4ade7@osg.samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1018 Lines: 36 Hi Javier, On 11/29/2016 04:00 PM, Javier Martinez Canillas wrote: > Hello Jacek, > > On 10/21/2016 12:52 PM, Javier Martinez Canillas wrote: >> If the driver is built as a module, autoload won't work because the module >> alias information is not filled. So user-space can't match the registered >> device with the corresponding module. >> >> Export the module alias information using the MODULE_DEVICE_TABLE() macro. >> >> Before this patch: >> >> $ modinfo drivers/leds//leds-netxbig.ko | grep alias >> alias: platform:leds-netxbig >> >> After this patch: >> >> $ modinfo drivers/leds//leds-netxbig.ko | grep alias >> alias: platform:leds-netxbig >> alias: of:N*T*Clacie,netxbig-ledsC* >> alias: of:N*T*Clacie,netxbig-leds >> >> Signed-off-by: Javier Martinez Canillas >> --- >> > > Any comments about this patch? I mistakenly marked it as merged. Sorry about that. Applied to the for-next branch of linux-leds.git. -- Best regards, Jacek Anaszewski