Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756654AbcK2Q7F (ORCPT ); Tue, 29 Nov 2016 11:59:05 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:32834 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755947AbcK2Q65 (ORCPT ); Tue, 29 Nov 2016 11:58:57 -0500 To: Brian King Cc: Benjamin Herrenschmidt , linux-scsi@vger.kernel.org, "linux-kernel\@vger.kernel.org" , linuxppc dev list Subject: Re: [PATCH] scsi/ipr: Fix runaway IRQs when falling back from MSI to LSI From: "Martin K. Petersen" Organization: Oracle Corporation References: <1479947042.10230.88.camel@kernel.crashing.org> Date: Tue, 29 Nov 2016 11:58:38 -0500 In-Reply-To: <1479947042.10230.88.camel@kernel.crashing.org> (Benjamin Herrenschmidt's message of "Thu, 24 Nov 2016 11:24:02 +1100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 485 Lines: 13 >>>>> "Benjamin" == Benjamin Herrenschmidt writes: Benjamin> LSIs must be ack'ed with an MMIO otherwise they remain Benjamin> asserted forever. This is controlled by the "clear_isr" flag. Benjamin> While we set that flag properly when deciding initially Benjamin> whether to use LSIs or MSIs, we fail to set it if we first Benjamin> chose MSIs, the test fails, then fallback to LSIs. Brian: Please review! -- Martin K. Petersen Oracle Linux Engineering