Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758151AbcK2RSh (ORCPT ); Tue, 29 Nov 2016 12:18:37 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:33351 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758055AbcK2RRi (ORCPT ); Tue, 29 Nov 2016 12:17:38 -0500 MIME-Version: 1.0 In-Reply-To: <20161129171333.GE9796@dhcp22.suse.cz> References: <20161121215639.GF13371@merlins.org> <20161121230332.GA3767@htj.duckdns.org> <7189b1f6-98c3-9a36-83c1-79f2ff4099af@suse.cz> <20161122164822.GA5459@htj.duckdns.org> <3e8eeadb-8dde-2313-f6e3-ef7763832104@suse.cz> <20161128171907.GA14754@htj.duckdns.org> <20161129072507.GA31671@dhcp22.suse.cz> <20161129163807.GB19454@htj.duckdns.org> <20161129171333.GE9796@dhcp22.suse.cz> From: Linus Torvalds Date: Tue, 29 Nov 2016 09:17:37 -0800 X-Google-Sender-Auth: _uEtONZ54J17fnpZDzkVIhE-1Aw Message-ID: Subject: Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort allocations in blkcg To: Michal Hocko Cc: Vlastimil Babka , Tejun Heo , Jens Axboe , linux-mm , LKML , Joonsoo Kim , Marc MERLIN Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 452 Lines: 15 On Tue, Nov 29, 2016 at 9:13 AM, Michal Hocko wrote: > How does this look like? No. I *really* want people to write out that "I am ok with the allocation failing". It's not an "inconvenience". It's a sign that you are competent and that you know it will fail, and that you can handle it. If you don't show that you know that, we warn about it. And no, "GFP_NOWAIT" does *not* mean "I have a good fallback". Linus