Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932978AbcK2R7I (ORCPT ); Tue, 29 Nov 2016 12:59:08 -0500 Received: from mail-oi0-f45.google.com ([209.85.218.45]:34950 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754392AbcK2R7A (ORCPT ); Tue, 29 Nov 2016 12:59:00 -0500 MIME-Version: 1.0 In-Reply-To: <1738700.ehr6xDaTh1@avalon> References: <1480395884-5471-1-git-send-email-john.stultz@linaro.org> <1480395884-5471-3-git-send-email-john.stultz@linaro.org> <1738700.ehr6xDaTh1@avalon> From: John Stultz Date: Tue, 29 Nov 2016 09:58:59 -0800 Message-ID: Subject: Re: [RFC][PATCH 2/5 v2] drm/bridge: adv7511: Switch to using drm_kms_helper_hotplug_event() To: Laurent Pinchart Cc: lkml , David Airlie , Archit Taneja , Wolfram Sang , Lars-Peter Clausen , "dri-devel@lists.freedesktop.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1792 Lines: 48 On Mon, Nov 28, 2016 at 10:50 PM, Laurent Pinchart wrote: > Hi John, > > Thank you for the patch. > > On Monday 28 Nov 2016 21:04:41 John Stultz wrote: >> In chasing down a previous issue with EDID probing from calling >> drm_helper_hpd_irq_event() from irq context, Laurent noticed >> that the DRM documentation suggests that >> drm_kms_helper_hotplug_event() should be used instead. >> >> Thus this patch replaces drm_helper_hpd_irq_event() with >> drm_kms_helper_hotplug_event(). >> >> Cc: David Airlie >> Cc: Archit Taneja >> Cc: Wolfram Sang >> Cc: Lars-Peter Clausen >> Cc: Laurent Pinchart >> Cc: dri-devel@lists.freedesktop.org >> Signed-off-by: John Stultz >> --- >> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c >> b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index b38e743..2caca0c >> 100644 >> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c >> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c >> @@ -406,7 +406,7 @@ static void adv7511_irq_work(struct work_struct *work) >> { >> struct adv7511 *adv7511 = container_of(work, struct adv7511, > irq_work); >> >> - drm_helper_hpd_irq_event(adv7511->connector.dev); >> + drm_kms_helper_hotplug_event(adv7511->connector.dev); > > That's nice, but you must first update adv7511->connector.status (and as an > optimization only call drm_kms_helper_hotplug_event() if the status has > changed). Apologies for not seeing that subtlety. Thanks for pointing it out, I've updated my patch. thanks -john