Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755722AbcK2TY0 (ORCPT ); Tue, 29 Nov 2016 14:24:26 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:35776 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751765AbcK2TYR (ORCPT ); Tue, 29 Nov 2016 14:24:17 -0500 Date: Tue, 29 Nov 2016 20:24:26 +0100 From: Greg KH To: Davidlohr Bueso Cc: linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: Re: [PATCH] drivers/usb: use READ_ONCE instead of deprecated ACCESS_ONCE Message-ID: <20161129192426.GC3155@kroah.com> References: <1479585265-7906-1-git-send-email-dave@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1479585265-7906-1-git-send-email-dave@stgolabs.net> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 633 Lines: 16 On Sat, Nov 19, 2016 at 11:54:25AM -0800, Davidlohr Bueso wrote: > With the new standardized functions, we can replace all ACCESS_ONCE() > calls across relevant drivers/usb/. > > ACCESS_ONCE() does not work reliably on non-scalar types. For example > gcc 4.6 and 4.7 might remove the volatile tag for such accesses during > the SRA (scalar replacement of aggregates) step: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 > > Update the new calls regardless of if it is a scalar type, this is > cleaner than having three alternatives. > > Signed-off-by: Davidlohr Bueso Again, fix your From: line please.