From: Arnd Bergmann <arnd@arndb.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Robin van der Gracht <robin@protonic.nl>,
        Linus Walleij <linus.walleij@linaro.org>,
        Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] auxdisplay: ht16k33: select required CONFIG_FB_CFB_* helpers
Date: Tue, 29 Nov 2016 20:55:50 +0100
Message-ID: <5786817.KaNgRCUMYq@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <20161129194247.GA27926@kroah.com>
References: <1480067407-14111-1-git-send-email-robin@protonic.nl> <20161129194247.GA27926@kroah.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1506
Lines: 44

On Tuesday, November 29, 2016 8:42:47 PM CET Greg Kroah-Hartman wrote:
> On Fri, Nov 25, 2016 at 10:50:07AM +0100, Robin van der Gracht wrote:
> > This selects the respective helpers required in addition to the one
> > Arnd Bergmann pointer out earlier.
> > 
> > Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> > ---
> > This is a responce to https://lkml.org/lkml/2016/11/25/66
> > This patch complements the changes Arnd submitted earlier. 
> > 
> >  drivers/auxdisplay/Kconfig | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> > index b8bbfc6..4ef4c5c 100644
> > --- a/drivers/auxdisplay/Kconfig
> > +++ b/drivers/auxdisplay/Kconfig
> > @@ -132,6 +132,9 @@ config HT16K33
> >  	tristate "Holtek Ht16K33 LED controller with keyscan"
> >  	depends on FB && OF && I2C && INPUT
> >  	select FB_SYS_FOPS
> > +	select FB_CFB_FILLRECT
> > +	select FB_CFB_COPYAREA
> > +	select FB_CFB_IMAGEBLIT
> >  	select INPUT_MATRIXKMAP
> >  	select FB_BACKLIGHT
> >  	help
> 
> What tree is this patch against?
> 
> thanks,
> 
> greg k-h
> 

It's on top of my patch "auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS"
from a few days ago. I guess Robin expected you to have picked that
up, while you expected him to combine it with the new changes.

Robin, I think it's easier if you send the combined patch and
add "Reported-by: Arnd Bergmann <arnd@arndb.de>", as Greg has
probably already droppped my earlier patch from his queue.

	Arnd