Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756989AbcK2UgE (ORCPT ); Tue, 29 Nov 2016 15:36:04 -0500 Received: from mail-io0-f195.google.com ([209.85.223.195]:35679 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752771AbcK2Uf6 (ORCPT ); Tue, 29 Nov 2016 15:35:58 -0500 MIME-Version: 1.0 In-Reply-To: <20161129195721.GI2697@decadent.org.uk> References: <20161129131922.GA31466@angband.pl> <20161129135118.24696-1-kilobyte@angband.pl> <30bb2db4-47bd-0c35-8328-ef032b551f06@suse.com> <20161129195721.GI2697@decadent.org.uk> From: Linus Torvalds Date: Tue, 29 Nov 2016 12:35:57 -0800 X-Google-Sender-Auth: _xwt3Nao4GZ5MH0eqN7QJEEz4Kg Message-ID: Subject: Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm To: Ben Hutchings Cc: Michal Marek , Adam Borowski , Greg Kroah-Hartman , Linux Kbuild mailing list , Debian kernel maintainers , "linux-arch@vger.kernel.org" , Arnd Bergmann , Ingo Molnar , Nicholas Piggin , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 877 Lines: 22 On Tue, Nov 29, 2016 at 11:57 AM, Ben Hutchings wrote: > > If the modversion is missing then the fallback should be to a full > vermagic match, i.e. including the release string. Something like > this (untested): This really seems way too complicated for this situation. And it's wrong too. The whole point of modversions was that you didn't want to do the full version check. We already know there were *some* crc's (we checked that at the top of check_version(), but we've also checked it in "same_magic()" - it's what makes us ignore the exact version number), but this particular symbol doesn't have a crc. Just let it through, because we have bugs in binutils. So your extra complexity logic seems actively wrong. It makes MODVERSIONS not work at all, rather than limp along. You're better off just not having MODVERSIONS. Linus