Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756182AbcK2Uy2 (ORCPT ); Tue, 29 Nov 2016 15:54:28 -0500 Received: from mail-io0-f193.google.com ([209.85.223.193]:35213 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752187AbcK2UyT (ORCPT ); Tue, 29 Nov 2016 15:54:19 -0500 MIME-Version: 1.0 In-Reply-To: <1480358514-2894-1-git-send-email-a.mathur@samsung.com> References: <1480358514-2894-1-git-send-email-a.mathur@samsung.com> From: Aniroop Mathur Date: Wed, 30 Nov 2016 02:24:17 +0530 X-Google-Sender-Auth: XwCoSSqnF3KX0pzM6DiU3ubMWYc Message-ID: Subject: Re: [PATCH] Input: touchscreen: edt_ft5x06 - change msleep to usleep_range for small msecs To: simon.budig@kernelconcepts.de, daniel.wagener@kernelconcepts.de, LW@karo-electronics.de, Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: s.samuel@samsung.com, r.mahale@samsung.com, Aniroop Mathur , Aniroop Mathur Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uATKsWFs022214 Content-Length: 2170 Lines: 58 Dear Simon Budig / Daniel Wagener / Lothar Waßmann, Greetings! I am Aniroop Mathur from Samsung R&D Institute, India. I have submitted one patch as below for review to Linux Open Source. The problem is that we do not have the hardware available with us to test it and we would like to test it before actually applying it. As you are the author of this driver, I am contacting you to request you to provide your feedback upon this patch. Also if you have the hardware available, could you please help to test this patch on your hardware? or could you provide contact points of individuals who could support to test it? Thank you! BR, Aniroop Mathur On Tue, Nov 29, 2016 at 12:11 AM, Aniroop Mathur wrote: > msleep(1~20) may not do what the caller intends, and will often sleep longer. > (~20 ms actual sleep for any value given in the 1~20ms range) > This is not the desired behaviour for many cases like device resume time, > device suspend time, device enable time, retry logic, etc. > Thus, change msleep to usleep_range for precise wakeups. > > Signed-off-by: Aniroop Mathur > --- > drivers/input/touchscreen/edt-ft5x06.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c > index 703e295..379dd31 100644 > --- a/drivers/input/touchscreen/edt-ft5x06.c > +++ b/drivers/input/touchscreen/edt-ft5x06.c > @@ -67,7 +67,7 @@ > #define EDT_SWITCH_MODE_RETRIES 10 > #define EDT_SWITCH_MODE_DELAY 5 /* msec */ > #define EDT_RAW_DATA_RETRIES 100 > -#define EDT_RAW_DATA_DELAY 1 /* msec */ > +#define EDT_RAW_DATA_DELAY 1000 /* usec */ > > enum edt_ver { > M06, > @@ -664,7 +664,7 @@ static ssize_t edt_ft5x06_debugfs_raw_data_read(struct file *file, > } > > do { > - msleep(EDT_RAW_DATA_DELAY); > + usleep_range(EDT_RAW_DATA_DELAY, EDT_RAW_DATA_DELAY + 100); > val = edt_ft5x06_register_read(tsdata, 0x08); > if (val < 1) > break; > -- > 2.6.2 >