Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932940AbcK2VC7 (ORCPT ); Tue, 29 Nov 2016 16:02:59 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:35215 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752706AbcK2VCv (ORCPT ); Tue, 29 Nov 2016 16:02:51 -0500 MIME-Version: 1.0 In-Reply-To: <1480362924-5224-1-git-send-email-a.mathur@samsung.com> References: <1480362924-5224-1-git-send-email-a.mathur@samsung.com> From: Aniroop Mathur Date: Wed, 30 Nov 2016 02:32:50 +0530 X-Google-Sender-Auth: KZlTZsatYsk7iVa5M8mz7RIxmz8 Message-ID: Subject: Re: [PATCH] Input: mouse: synaptics - change msleep to usleep_range for small msecs To: mike@compulab.co.il, grinberg@compulab.co.il, Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: s.samuel@samsung.com, r.mahale@samsung.com, Aniroop Mathur , Aniroop Mathur Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2216 Lines: 57 Dear Mike Rapoport, Igor Grinberg, Greetings! I am Aniroop Mathur from Samsung R&D Institute, India. I have submitted one patch as below for review to Linux Open Source. The problem is that we do not have the hardware available with us to test it and we would like to test it before actually applying it. As you are the author of this driver, I am contacting you to request you provide your feedback upon this patch. Also if you have the hardware available, could you please help to test this patch on your hardware? or could you provide contact points of individuals who could support to test it? Thank you! BR, Aniroop Mathur On Tue, Nov 29, 2016 at 1:25 AM, Aniroop Mathur wrote: > msleep(1~20) may not do what the caller intends, and will often sleep longer. > (~20 ms actual sleep for any value given in the 1~20ms range) > This is not the desired behaviour for many cases like device resume time, > device suspend time, device enable time, retry logic, etc. > Thus, change msleep to usleep_range for precise wakeups. > > Signed-off-by: Aniroop Mathur > --- > drivers/input/mouse/synaptics_i2c.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/mouse/synaptics_i2c.c b/drivers/input/mouse/synaptics_i2c.c > index aa7c5da..4d688a6 100644 > --- a/drivers/input/mouse/synaptics_i2c.c > +++ b/drivers/input/mouse/synaptics_i2c.c > @@ -29,7 +29,7 @@ > * after soft reset, we should wait for 1 ms > * before the device becomes operational > */ > -#define SOFT_RESET_DELAY_MS 3 > +#define SOFT_RESET_DELAY_US 3000 > /* and after hard reset, we should wait for max 500ms */ > #define HARD_RESET_DELAY_MS 500 > > @@ -311,7 +311,7 @@ static int synaptics_i2c_reset_config(struct i2c_client *client) > if (ret) { > dev_err(&client->dev, "Unable to reset device\n"); > } else { > - msleep(SOFT_RESET_DELAY_MS); > + usleep_range(SOFT_RESET_DELAY_US, SOFT_RESET_DELAY_US + 100); > ret = synaptics_i2c_config(client); > if (ret) > dev_err(&client->dev, "Unable to config device\n"); > -- > 2.6.2 >