Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753682AbcK2WjL (ORCPT ); Tue, 29 Nov 2016 17:39:11 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:45706 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751485AbcK2WjD (ORCPT ); Tue, 29 Nov 2016 17:39:03 -0500 Date: Tue, 29 Nov 2016 14:39:16 -0800 From: Andrew Morton To: Dan Streetman Cc: Vitaly Wool , Linux-MM , linux-kernel , Arnd Bergmann , Dan Carpenter Subject: Re: [PATCH 0/2] z3fold fixes Message-Id: <20161129143916.f24c141c1a264bad1220031e@linux-foundation.org> In-Reply-To: References: <20161126201534.5d5e338f678b478e7a7b8dc3@gmail.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1328 Lines: 25 On Tue, 29 Nov 2016 17:33:19 -0500 Dan Streetman wrote: > On Sat, Nov 26, 2016 at 2:15 PM, Vitaly Wool wrote: > > Here come 2 patches with z3fold fixes for chunks counting and locking. As commit 50a50d2 ("z3fold: don't fail kernel build is z3fold_header is too big") was NAK'ed [1], I would suggest that we removed that one and the next z3fold commit cc1e9c8 ("z3fold: discourage use of pages that weren't compacted") and applied the coming 2 instead. > > Instead of adding these onto all the previous ones, could you redo the > entire z3fold series? I think it'll be simpler to review the series > all at once and that would remove some of the stuff from previous > patches that shouldn't be there. > > If that's ok with Andrew, of course, but I don't think any of the > z3fold patches have been pushed to Linus yet. Sounds good to me. I had a few surprise rejects when merging these two, which indicates that things might be out of sync. I presently have: z3fold-limit-first_num-to-the-actual-range-of-possible-buddy-indexes.patch z3fold-make-pages_nr-atomic.patch z3fold-extend-compaction-function.patch z3fold-use-per-page-spinlock.patch z3fold-discourage-use-of-pages-that-werent-compacted.patch z3fold-fix-header-size-related-issues.patch z3fold-fix-locking-issues.patch