Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755003AbcK3AjD (ORCPT ); Tue, 29 Nov 2016 19:39:03 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:37674 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753214AbcK3Ai4 (ORCPT ); Tue, 29 Nov 2016 19:38:56 -0500 Date: Tue, 29 Nov 2016 19:38:53 -0500 (EST) Message-Id: <20161129.193853.827524417068912706.davem@davemloft.net> To: jbrunet@baylibre.com Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, f.fainelli@gmail.com, carlo@caione.org, khilman@baylibre.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, martin.blumenstingl@googlemail.com, neolynx@gmail.com, andrew@lunn.ch, narmstrong@baylibre.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue From: David Miller In-Reply-To: <1480326409-25419-1-git-send-email-jbrunet@baylibre.com> References: <1480326409-25419-1-git-send-email-jbrunet@baylibre.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 Nov 2016 15:39:31 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 879 Lines: 19 From: Jerome Brunet Date: Mon, 28 Nov 2016 10:46:45 +0100 > This patchset fixes an issue with the OdroidC2 board (DWMAC + RTL8211F). > The platform seems to enter LPI on the Rx path too often while performing > relatively high TX transfer. This eventually break the link (both Tx and > Rx), and require to bring the interface down and up again to get the Rx > path working again. > > The root cause of this issue is not fully understood yet but disabling EEE > advertisement on the PHY prevent this feature to be negotiated. > With this change, the link is stable and reliable, with the expected > throughput performance. > > The patchset adds options in the generic phy driver to disable EEE > advertisement, through device tree. The way it is done is very similar > to the handling of the max-speed property. Patches 1-3 applied to net-next, thanks.