Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755032AbcK3Anb (ORCPT ); Tue, 29 Nov 2016 19:43:31 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:33781 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752250AbcK3AnY (ORCPT ); Tue, 29 Nov 2016 19:43:24 -0500 Subject: Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue To: David Miller , jbrunet@baylibre.com References: <1480326409-25419-1-git-send-email-jbrunet@baylibre.com> <20161129.193853.827524417068912706.davem@davemloft.net> Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, carlo@caione.org, khilman@baylibre.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, martin.blumenstingl@googlemail.com, neolynx@gmail.com, andrew@lunn.ch, narmstrong@baylibre.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Florian Fainelli Message-ID: Date: Tue, 29 Nov 2016 16:43:20 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161129.193853.827524417068912706.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1126 Lines: 26 On 11/29/2016 04:38 PM, David Miller wrote: > From: Jerome Brunet > Date: Mon, 28 Nov 2016 10:46:45 +0100 > >> This patchset fixes an issue with the OdroidC2 board (DWMAC + RTL8211F). >> The platform seems to enter LPI on the Rx path too often while performing >> relatively high TX transfer. This eventually break the link (both Tx and >> Rx), and require to bring the interface down and up again to get the Rx >> path working again. >> >> The root cause of this issue is not fully understood yet but disabling EEE >> advertisement on the PHY prevent this feature to be negotiated. >> With this change, the link is stable and reliable, with the expected >> throughput performance. >> >> The patchset adds options in the generic phy driver to disable EEE >> advertisement, through device tree. The way it is done is very similar >> to the handling of the max-speed property. > > Patches 1-3 applied to net-next, thanks. Meh, there was a v4 submitted shortly after, and I objected to the whole idea of using that kind of Device Tree properties to disable EEE, we can send reverts though.. -- Florian