Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756308AbcK3BOA (ORCPT ); Tue, 29 Nov 2016 20:14:00 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:38764 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755816AbcK3BNj (ORCPT ); Tue, 29 Nov 2016 20:13:39 -0500 Date: Tue, 29 Nov 2016 20:13:31 -0500 (EST) Message-Id: <20161129.201331.2207317476589573523.davem@davemloft.net> To: f.fainelli@gmail.com Cc: jbrunet@baylibre.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, carlo@caione.org, khilman@baylibre.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, martin.blumenstingl@googlemail.com, neolynx@gmail.com, andrew@lunn.ch, narmstrong@baylibre.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue From: David Miller In-Reply-To: References: <1480326409-25419-1-git-send-email-jbrunet@baylibre.com> <20161129.193853.827524417068912706.davem@davemloft.net> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 Nov 2016 16:14:09 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1436 Lines: 35 From: Florian Fainelli Date: Tue, 29 Nov 2016 16:43:20 -0800 > On 11/29/2016 04:38 PM, David Miller wrote: >> From: Jerome Brunet >> Date: Mon, 28 Nov 2016 10:46:45 +0100 >> >>> This patchset fixes an issue with the OdroidC2 board (DWMAC + RTL8211F). >>> The platform seems to enter LPI on the Rx path too often while performing >>> relatively high TX transfer. This eventually break the link (both Tx and >>> Rx), and require to bring the interface down and up again to get the Rx >>> path working again. >>> >>> The root cause of this issue is not fully understood yet but disabling EEE >>> advertisement on the PHY prevent this feature to be negotiated. >>> With this change, the link is stable and reliable, with the expected >>> throughput performance. >>> >>> The patchset adds options in the generic phy driver to disable EEE >>> advertisement, through device tree. The way it is done is very similar >>> to the handling of the max-speed property. >> >> Patches 1-3 applied to net-next, thanks. > > Meh, there was a v4 submitted shortly after, and I objected to the whole > idea of using that kind of Device Tree properties to disable EEE, we can > send reverts though.. Sorry, I lost this in all the discussion, I can revert. Just send me a revert of the entire merge commit a152c91889556df17ca6d8ea134fb2cb4ac9f893 with a short description of why and I'll apply it. Thanks.