Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755713AbcK3H5p (ORCPT ); Wed, 30 Nov 2016 02:57:45 -0500 Received: from protonic.xs4all.nl ([83.163.252.89]:14589 "EHLO protonic.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751382AbcK3H5i (ORCPT ); Wed, 30 Nov 2016 02:57:38 -0500 Date: Wed, 30 Nov 2016 08:57:35 +0100 From: Robin van der Gracht To: Greg Kroah-Hartman Cc: Arnd Bergmann , Linus Walleij , Miguel Ojeda Sandonis , linux-kernel@vger.kernel.org Subject: Re: [PATCH] auxdisplay: ht16k33: select required CONFIG_FB_CFB_* helpers Message-ID: <20161130085735.7f6fc4cc@erd979> In-Reply-To: <20161129200430.GA21400@kroah.com> References: <1480067407-14111-1-git-send-email-robin@protonic.nl> <20161129194247.GA27926@kroah.com> <5786817.KaNgRCUMYq@wuerfel> <20161129200430.GA21400@kroah.com> Organization: Protonic Holland X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1942 Lines: 57 On Tue, 29 Nov 2016 21:04:30 +0100 Greg Kroah-Hartman wrote: > On Tue, Nov 29, 2016 at 08:55:50PM +0100, Arnd Bergmann wrote: > > On Tuesday, November 29, 2016 8:42:47 PM CET Greg Kroah-Hartman wrote: > > > On Fri, Nov 25, 2016 at 10:50:07AM +0100, Robin van der Gracht wrote: > > > > This selects the respective helpers required in addition to the one > > > > Arnd Bergmann pointer out earlier. > > > > > > > > Signed-off-by: Robin van der Gracht > > > > --- > > > > This is a responce to https://lkml.org/lkml/2016/11/25/66 > > > > This patch complements the changes Arnd submitted earlier. > > > > > > > > drivers/auxdisplay/Kconfig | 3 +++ > > > > 1 file changed, 3 insertions(+) > > > > > > > > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig > > > > index b8bbfc6..4ef4c5c 100644 > > > > --- a/drivers/auxdisplay/Kconfig > > > > +++ b/drivers/auxdisplay/Kconfig > > > > @@ -132,6 +132,9 @@ config HT16K33 > > > > tristate "Holtek Ht16K33 LED controller with keyscan" > > > > depends on FB && OF && I2C && INPUT > > > > select FB_SYS_FOPS > > > > + select FB_CFB_FILLRECT > > > > + select FB_CFB_COPYAREA > > > > + select FB_CFB_IMAGEBLIT > > > > select INPUT_MATRIXKMAP > > > > select FB_BACKLIGHT > > > > help > > > > > > What tree is this patch against? > > > > > > thanks, > > > > > > greg k-h > > > > > > > It's on top of my patch "auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS" > > from a few days ago. I guess Robin expected you to have picked that > > up, while you expected him to combine it with the new changes. > > > > Robin, I think it's easier if you send the combined patch and > > add "Reported-by: Arnd Bergmann ", as Greg has > > probably already droppped my earlier patch from his queue. > > Yes, it's not in my queue anymore. > > thanks, > > greg k-h I'll create a new patch. Regards, Robin