Date: Wed, 30 Nov 2016 17:03:27 +0800
From: Baoquan He <bhe@redhat.com>
To: xlpang@redhat.com
Cc: Joerg Roedel <joro@8bytes.org>, Don Brace <don.brace@microsemi.com>,
        Myron Stowe <myron.stowe@redhat.com>, kexec@lists.infradead.org,
        LKML <linux-kernel@vger.kernel.org>, iommu@lists.linux-foundation.org,
        Myron Stowe <myron.stowe@gmail.com>, Dave Young <dyoung@redhat.com>,
        David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] iommu/vt-d: Flush old iotlb for kdump when the device
 gets context mapped
Message-ID: <20161130090327.GA4192@x1>
References: <1479286950-21885-1-git-send-email-xlpang@redhat.com>
 <582C232F.6080205@redhat.com>
 <CAL-B5D1kkWE4e6P1xY1Cgkf-7+nBXH=C7g21=phEzmM4FPZRRQ@mail.gmail.com>
 <582D1A40.409@redhat.com>
 <20161129143547.GG2078@8bytes.org>
 <583E8A9B.7070906@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <583E8A9B.7070906@redhat.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2283
Lines: 53

On 11/30/16 at 04:15pm, Xunlei Pang wrote:
> On 11/29/2016 at 10:35 PM, Joerg Roedel wrote:
> > On Thu, Nov 17, 2016 at 10:47:28AM +0800, Xunlei Pang wrote:
> >> As per the comment, the code here only needs to flush context caches
> >> for the special domain 0 which is used to tag the
> >> non-present/erroneous caches, seems we should flush the old domain id
> >> of present entries for kdump according to the analysis, other than the
> >> new-allocated domain id. Let me ponder more on this.
> > Flushing the context entry only is fine. The old domain-id will not be
> > re-used anyway, so there is no point in reading it out of the context
> > table and flush it.
> 
> Do you mean to flush the context entry using the new-allocated domain id?
> 
> Yes, old domain-id will not be re-used as they were reserved when copy, but
> may still be cached by in-flight DMA access.

Joerg is saying you have flushed context entry which is the ingress,
new DMA can't get an entrance to hit the iotlb accordingly. Since you
have bolted the ingress gate. I guess

> 
> Here is what the things seem to be from my understanding, and why I want to
> flush using the old domain id:
> 1) In kdump mode, old tables are copied, and all the iommu caches are flushed.
> 2) There comes some in-flight DMA before the device's new context is mapped,
>     so translation caches(context, iotlb, etc) are created tagging old domain-id
>     in the iommu hardware.
> 3) At the driver probe stage, the device is reset , and no in-flight DMA will exist.
>     Here I assumed that the device reset won't flush the old caches in the iommu
>     hardware related to this device. I haven't found any relevant specification, please
>     correct me if I am wrong.
> 4) Then new context is setup, and new DMA is initiated, hit old cache that was
>     created in 2) as currently there's no such flush action, so DMAR fault happens.
> 
> I already posted v2 to flush context/iotlb using the old domain-id:
> https://lkml.org/lkml/2016/11/18/514
> 
> Regards,
> Xunlei
> 
> >
> > Also, please add a Fixes-tag when you re-post this patch.
> >
> >
> > 	Joerg
> >
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec