Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932409AbcK3JKc (ORCPT ); Wed, 30 Nov 2016 04:10:32 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:59834 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757305AbcK3JJ7 (ORCPT ); Wed, 30 Nov 2016 04:09:59 -0500 Date: Wed, 30 Nov 2016 10:01:20 +0100 From: Greg KH To: Yan Laijun Cc: devel@driverdev.osuosl.org, sergio.paracuellos@gmail.com, linux-kernel@vger.kernel.org, bhumirks@gmail.com Subject: Re: [PATCH] Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings. Message-ID: <20161130090120.GB32672@kroah.com> References: <20161130042913.GA28831@yanlaijun-OptiPlex-9020> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161130042913.GA28831@yanlaijun-OptiPlex-9020> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 894 Lines: 26 On Wed, Nov 30, 2016 at 12:29:13PM +0800, Yan Laijun wrote: > Fixed checkpatch warning "line over 80 characters" in > wlan-ng/hfa384x_usb.c file. > > Signed-off-by: Yan Laijun > --- > drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c > index 5f11f6e..3447fc5 100644 > --- a/drivers/staging/wlan-ng/hfa384x_usb.c > +++ b/drivers/staging/wlan-ng/hfa384x_usb.c > @@ -3037,7 +3037,7 @@ static void hfa384x_usbin_callback(struct urb *urb) > { > struct wlandevice *wlandev = urb->context; > struct hfa384x *hw; > - union hfa384x_usbin *usbin = (union hfa384x_usbin *)urb->transfer_buffer; > + union hfa384x_usbin *usbin = NULL; Why set this to NULL if you then assign it to something else a few lines later? thanks, greg k-h