Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755990AbcK3Jsm (ORCPT ); Wed, 30 Nov 2016 04:48:42 -0500 Received: from protonic.xs4all.nl ([83.163.252.89]:15029 "EHLO protonic.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754322AbcK3JsP (ORCPT ); Wed, 30 Nov 2016 04:48:15 -0500 From: Robin van der Gracht To: Greg Kroah-Hartman Cc: Linus Walleij , Arnd Bergmann , Miguel Ojeda Sandonis , linux-kernel@vger.kernel.org, Robin van der Gracht Subject: [PATCH] auxdisplay: ht16k33: select framebuffer helper modules Date: Wed, 30 Nov 2016 10:47:39 +0100 Message-Id: <1480499259-5610-1-git-send-email-robin@protonic.nl> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 980 Lines: 33 The new driver caused a rare randconfig failure: drivers/auxdisplay/ht16k33.o:(.data.ht16k33_fb_ops+0xc): undefined reference to `fb_sys_read' drivers/auxdisplay/ht16k33.o:(.data.ht16k33_fb_ops+0x10): undefined reference to `fb_sys_write' This selects the respective helper modules. Reported-by: Arnd Bergmann Signed-off-by: Robin van der Gracht --- Greg: Bugfix for your char-misc-* tree drivers/auxdisplay/Kconfig | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig index a230ea7..4ef4c5c 100644 --- a/drivers/auxdisplay/Kconfig +++ b/drivers/auxdisplay/Kconfig @@ -131,6 +131,10 @@ config IMG_ASCII_LCD config HT16K33 tristate "Holtek Ht16K33 LED controller with keyscan" depends on FB && OF && I2C && INPUT + select FB_SYS_FOPS + select FB_CFB_FILLRECT + select FB_CFB_COPYAREA + select FB_CFB_IMAGEBLIT select INPUT_MATRIXKMAP select FB_BACKLIGHT help -- 2.7.4