Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757660AbcK3J67 (ORCPT ); Wed, 30 Nov 2016 04:58:59 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:50862 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932336AbcK3J6k (ORCPT ); Wed, 30 Nov 2016 04:58:40 -0500 X-AuditID: cbfec7ef-f79e76d000005b57-d8-583ea2cc44c5 Subject: Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x To: Peter Rosin , Phong Vo Cc: Mika Westerberg , "Rafael J. Wysocki" , Richard Purdie , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Loc Ho , Thang Nguyen , patches , Tin Huynh From: Jacek Anaszewski Message-id: Date: Wed, 30 Nov 2016 10:58:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <959f287f-74c1-d790-4f36-9c7ac053bc8e@axentia.se> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0hTcRTH+e3eu12Xq9tcdbSHNNLQUJOEbqkjMWLgH5UEmRA58qLSfLSr ovby/UrJXBbZbFbYzPnId2marlB84FtDIRFMEzNMDR+JM+e18L/P4XwO53x//EhMXEJYkUEh 4YwqRKGU8oV4TctKl0PnS5nP8ay1w3TiSCZO6xofILq/TsOnq2dKEf2o9rOATuhc5NMNBi2i U4sXEd3Z0UfQ9XUTBN2S5kuvpqqJM+byubJ5JH/c9Ewgf952UV41mILLP2iXCflCxaELfF+h mz+jDIpkVE4yP2HgfPwrPKxZEpX8fQDFIh2VjkgSKBd4O+ybjsw2cC/0jJbx05GQFFOvEfT0 TWNcsYCgrdHI5ywXMOo7eP+tkaE8gismEXwqy8ZMlgXlCeO/ZwkTS6hTEKddxU0SRnXzICOv ADc1+JQzrEz94JlYRMlA093AN92EUzZQPnbVhHsoH6j/ynDGblhWj25Omm3YtUkPNxmjTsOk MYng2Boqi39uXg1UnwCmvqwLuJgHoaIJ4wKcBePI2lYYC5hurRJwfAD61fdxblaNoLdlmOAK PYLytDScs1whdv3P1uadkF3zBOMWiCA1WcwpcviWPIo49oCu6iGce6B2HEaXhrAsZJ27LVDu thC520LkI6wISZgINjiAYZ0dWUUwGxES4Hg9NLgCbXyiDmPr7Ds0kXDJgCgSSc1FU1nuPmJC EclGBxsQkJhUIkp5IfMRi/wV0TGMKvSaKkLJsAa0n8Sl+0QN+QOXxVSAIpy5wTBhjOpfl0ea WcWiW7fjhlZ6z83wSizPZ3qsf3ymn61v0OSdpHXe6zCutfJz0NVpo6IKjjBXctzzCu3K1DdR 6VHR3WPLuzQGdm44MDFBltQU0WId3zjmqsv4NU/lLHkN7hASK54npikvt/bmp56Wd+7ZxDjp vYsMlUp5iF2o9E27v22nbeH7LHu9FGcDFc72mIpV/AX5FzflQAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHIsWRmVeSWpSXmKPExsVy+t/xa7pbFtlFGExdbWHRcquXxWL5vn5G i8u75rBZbH2zjtFiyvYj7BbNZ76xWew9NJ/RomPNN0aLM6cvsVrs3vWU1eJYZ5TF747JrA48 Hh/Xf2L0mHZgNrvHvJOBHluutrN47Jn/g9Xj8ya5ALYoN5uM1MSU1CKF1Lzk/JTMvHRbpdAQ N10LJYW8xNxUW6UIXd+QICWFssScUiDPyAANODgHuAcr6dsluGV8alrMUnBQpKLt+RXGBsbl Al2MnBwSAiYS/1afZoKwxSQu3FvP1sXIxSEksIRR4u6DNhYI5xmjxKb97xlBqoQFnCUef3nP CmKLCFhKNM7/DVV0hkVies9PVhCHWeAik8SrOQ3MIFVsAoYSP1+8BtvBK2AnMef8XqAdHBws AqoSGx/EgoRFBSIkbq36yAhRIijxY/I9FhCbE6h8e+tEMJtZwEziy8vDrBC2vMTmNW+ZJzAK zELSMgtJ2SwkZQsYmVcxiqSWFuem5xYb6RUn5haX5qXrJefnbmIExuW2Yz+37GDsehd8iFGA g1GJh/fFBNsIIdbEsuLK3EOMEhzMSiK8PgvtIoR4UxIrq1KL8uOLSnNSiw8xmgL9MJFZSjQ5 H5gy8kriDU0MzS0NjYwtLMyNjJTEead+uBIuJJCeWJKanZpakFoE08fEwSnVwKgpMu+ukuSs PdNOfMwxf/5wmc8fxmdHXY+GPbqR+YNjs/WbW3NdnHxqjxz/IJD4It5l6cozPufXhctOPJ78 ump7F4dXZ8HMHhsJ++07W8MXqbZM5vtvp3LCwnLPj+ztTfMXOadMefEgd8fX2+7Vj0Xeiy1b yaqir24MTLo6tw1y36dc2vOjI0+JpTgj0VCLuag4EQB5J7HV4QIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161130095835eucas1p164aef8721f421f83e18611808a71bad6 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?Qikb7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?QikbU2Ftc3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgU29mdHdhcmUgRW5naW5l?= =?UTF-8?B?ZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjc1MjY=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161130030845epcas5p2369d1c7cabb765ef0039b8e8d5aaa965 X-RootMTR: 20161130030845epcas5p2369d1c7cabb765ef0039b8e8d5aaa965 References: <1480475311-14385-1-git-send-email-tnhuynh@apm.com> <302ebc57-6f52-b0ff-e354-0c67556a88ed@samsung.com> <7efcf021-72c9-328a-ad88-4c226e8b5d6d@samsung.com> <10443ff4-67ff-d474-401f-21fa7f33a9a5@samsung.com> <328afec669295cbc3a4338a4347e7067@mail.gmail.com> <959f287f-74c1-d790-4f36-9c7ac053bc8e@axentia.se> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2559 Lines: 66 Hi Peter, On 11/30/2016 10:36 AM, Peter Rosin wrote: > On 2016-11-30 10:10, Phong Vo wrote: >> +-----Original Message----- >> +From: Jacek Anaszewski [mailto:j.anaszewski@samsung.com] >> + >> +Hi Phong, >> + >> +On 11/30/2016 09:23 AM, Phong Vo wrote: >> +> +-----Original Message----- >> +> +From: Jacek Anaszewski [mailto:j.anaszewski@samsung.com] >> +> + >> +> +On 11/30/2016 09:06 AM, Tin Huynh wrote: >> +> +> On Wed, Nov 30, 2016 at 3:01 PM, Jacek Anaszewski wrote: >> +> +>> On 11/30/2016 08:51 AM, Jacek Anaszewski wrote: >> +> +>>> On 11/30/2016 04:08 AM, Tin Huynh wrote: >> +> +>>>> +static const struct acpi_device_id pca955x_acpi_ids[] = { >> +> +>>>> + { .id = "PCA9550", .driver_data = pca9550 }, >> +> +>>>> + { .id = "PCA9551", .driver_data = pca9551 }, >> +> +>>>> + { .id = "PCA9552", .driver_data = pca9552 }, >> +> +>>>> + { .id = "PCA9553", .driver_data = pca9553 }, >> +> +>>>> + { } >> +> +>> >> +> +>> >> +> +>> OK, I see that you brought back explicit properties in the >> +> +>> structure initializer. Is there some vital reason for that? >> +> >> +> It's not vital, but to make it consistent with what was done for >> +> pca963x, >> + >> +For pca963x I applied the version without explicit properties. >> +Note that this is consistent with pca963x_id array above the added >> +pca963x_acpi_ids. For pca955x the situation is the same. >> + >> +> and also per suggestion by Mika on reviewing a different driver >> +> mux:954x in another thread. >> + >> +Could you give a reference to that thread? In the review of V1 of this >> +patch Mika mentioned "{ "PCA9553", pca9553 }" scheme. >> + >> >> Actually it was Peter Rosin (not Mika) on linux-i2c and the reference to >> that is follows >> >> https://lkml.org/lkml/2016/11/18/732 >> >> I am including Robin here. > > I tried to say that I *personally* would have added the explicit > field specifiers but that it didn't seem like the norm and that both > of the approaches would therefore be perfectly ok by me (as there are > other examples of acpi id table initializers with field specifiers). > > To sum up, I don't really care. But my question lingers, is there some > compelling reason to not have the explicit field specifiers? It certainly downgrades code readability, but in case there is similar surrounding code there are two options to keep the things consistent - either stick to the current style or change it. IMHO the latter would generate only unnecessary noise in this particular case. -- Best regards, Jacek Anaszewski