Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756470AbcK3KE4 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 30 Nov 2016 05:04:56 -0500
Received: from mga04.intel.com ([192.55.52.120]:51188 "EHLO mga04.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1757785AbcK3KB6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 30 Nov 2016 05:01:58 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,573,1473145200"; 
   d="scan'208";a="1075506005"
Date: Wed, 30 Nov 2016 12:01:45 +0200
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Peter Rosin <peda@axentia.se>, Phong Vo <pvo@apm.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Richard Purdie <rpurdie@rpsys.net>, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
        Loc Ho <lho@apm.com>, Thang Nguyen <tqnguyen@apm.com>,
        patches <patches@apm.com>, Tin Huynh <tnhuynh@apm.com>
Subject: Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x
Message-ID: <20161130100145.GF1459@lahna.fi.intel.com>
References: <1480475311-14385-1-git-send-email-tnhuynh@apm.com>
 <302ebc57-6f52-b0ff-e354-0c67556a88ed@samsung.com>
 <7efcf021-72c9-328a-ad88-4c226e8b5d6d@samsung.com>
 <CANQ9TuAc8S-Q2Wx_qkJLLMd8dH7XDiGchB7EesPW1is9oFqWhA@mail.gmail.com>
 <c1d0e813-9e1e-b387-735a-2c8f39c5308e@samsung.com>
 <dc989a8b92342d2ceb63381ae9dc019d@mail.gmail.com>
 <10443ff4-67ff-d474-401f-21fa7f33a9a5@samsung.com>
 <328afec669295cbc3a4338a4347e7067@mail.gmail.com>
 <959f287f-74c1-d790-4f36-9c7ac053bc8e@axentia.se>
 <d1751969-3c8f-d4c0-8e99-74b9dd26bd98@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d1751969-3c8f-d4c0-8e99-74b9dd26bd98@samsung.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 424
Lines: 9

On Wed, Nov 30, 2016 at 10:58:33AM +0100, Jacek Anaszewski wrote:
> It certainly downgrades code readability, but in case there is
> similar surrounding code there are two options to keep the things
> consistent - either stick to the current style or change it.
> IMHO the latter would generate only unnecessary noise in this
> particular case.

Also that's the style we have been using when adding ACPI support to
drivers.