Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756364AbcK3KrX (ORCPT ); Wed, 30 Nov 2016 05:47:23 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:52810 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751532AbcK3KrO (ORCPT ); Wed, 30 Nov 2016 05:47:14 -0500 Message-ID: <1480502824.13978.8.camel@mtksdaap41> Subject: Re: [PATCH v10 11/13] drm/mediatek: add dsi rxtx control From: CK Hu To: YT Shen CC: , Philipp Zabel , David Airlie , Matthias Brugger , Daniel Kurtz , Mao Huang , Bibby Hsieh , "Daniel Vetter" , Thierry Reding , Jie Qiu , Maxime Ripard , Chris Wilson , shaoming chen , Jitao Shi , Boris Brezillon , Dan Carpenter , , , , , Sascha Hauer , , Date: Wed, 30 Nov 2016 18:47:04 +0800 In-Reply-To: <1480070076-6196-12-git-send-email-yt.shen@mediatek.com> References: <1480070076-6196-1-git-send-email-yt.shen@mediatek.com> <1480070076-6196-12-git-send-email-yt.shen@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1124 Lines: 35 Hi, YT: On Fri, 2016-11-25 at 18:34 +0800, YT Shen wrote: > add non-continuous clock mode and EOT packet control for dsi > I think commit title should be 'drm/mediatek: add non-continuous clock mode and EOT packet control for dsi', and commit message should describe more information about this modification. For example, what is the difference between with and without this patch. Does it fix any problem? Regards, CK > Signed-off-by: shaoming chen > Signed-off-by: YT Shen > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index 01df829..ded4202 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -399,6 +399,9 @@ static void mtk_dsi_rxtx_control(struct mtk_dsi *dsi) > break; > } > > + tmp_reg |= (dsi->mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) << 6; > + tmp_reg |= (dsi->mode_flags & MIPI_DSI_MODE_EOT_PACKET) >> 3; > + > writel(tmp_reg, dsi->regs + DSI_TXRX_CTRL); > } >