Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964836AbcK3LFZ (ORCPT ); Wed, 30 Nov 2016 06:05:25 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:30846 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754813AbcK3LFR (ORCPT ); Wed, 30 Nov 2016 06:05:17 -0500 Message-ID: <1480503911.13978.12.camel@mtksdaap41> Subject: Re: [PATCH v10 09/13] drm/mediatek: add mipi_tx data rate check From: CK Hu To: YT Shen CC: , Philipp Zabel , David Airlie , Matthias Brugger , Daniel Kurtz , Mao Huang , Bibby Hsieh , "Daniel Vetter" , Thierry Reding , Jie Qiu , Maxime Ripard , Chris Wilson , shaoming chen , Jitao Shi , Boris Brezillon , Dan Carpenter , , , , , Sascha Hauer , , Date: Wed, 30 Nov 2016 19:05:11 +0800 In-Reply-To: <1480070076-6196-10-git-send-email-yt.shen@mediatek.com> References: <1480070076-6196-1-git-send-email-yt.shen@mediatek.com> <1480070076-6196-10-git-send-email-yt.shen@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1078 Lines: 36 Hi, YT: On Fri, 2016-11-25 at 18:34 +0800, YT Shen wrote: > modify data rate limitation (>lGbps/lane) for mipitx > I think MT2701 DRM can work correctly without this patch. Why do you put this patch in MT2701 series? Maybe you can send this patch independently. Regards, CK > Signed-off-by: shaoming chen > Signed-off-by: YT Shen > --- > drivers/gpu/drm/mediatek/mtk_mipi_tx.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c > index fd84914..1ef00ac 100644 > --- a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c > +++ b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c > @@ -177,7 +177,9 @@ static int mtk_mipi_tx_pll_prepare(struct clk_hw *hw) > > dev_dbg(mipi_tx->dev, "prepare: %u Hz\n", mipi_tx->data_rate); > > - if (mipi_tx->data_rate >= 500000000) { > + if (mipi_tx->data_rate > 1250000000) { > + return -EINVAL; > + } else if (mipi_tx->data_rate >= 500000000) { > txdiv = 1; > txdiv0 = 0; > txdiv1 = 0;